Issue 2747813002: [Merge to M58] Prevent adding an empty email option in the feedback app in guest mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2747813002: [Merge to M58] Prevent adding an empty email option in the feedback app in guest mode (Closed)

Created:
3 years, 9 months ago by afakhry

Modified:
3 years, 9 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

[Merge to M58] Prevent adding an empty email option in the feedback app in guest mode TBR=xiyuan@chromium.org BUG=699287 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2742103002 Cr-Commit-Position: refs/heads/master@{#456223} (cherry picked from commit 449ca301d5722d443b57ab5fd5db36a57b9f821a) Review-Url: https://codereview.chromium.org/2747813002 . Cr-Commit-Position: refs/branch-heads/3029@{#153} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/644edabf28d40898cfc8180c6ec8b7933b7ab2e4

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/resources/feedback/js/feedback.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

afakhry

3 years, 9 months ago (2017-03-13 17:01:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
644edabf28d40898cfc8180c6ec8b7933b7ab2e4 (presubmit successful).