Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2742103002: Prevent adding an empty email option in the feedback app in guest mode (Closed)

Created:
3 years, 9 months ago by afakhry
Modified:
3 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent adding an empty email option in the feedback app in guest mode BUG=699287 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2742103002 Cr-Commit-Position: refs/heads/master@{#456223} Committed: https://chromium.googlesource.com/chromium/src/+/449ca301d5722d443b57ab5fd5db36a57b9f821a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/feedback/js/feedback.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
afakhry
Xiyuan, quick fix. :)
3 years, 9 months ago (2017-03-10 22:49:59 UTC) #3
xiyuan
lgtm
3 years, 9 months ago (2017-03-10 23:03:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742103002/1
3 years, 9 months ago (2017-03-10 23:05:58 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:10:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/449ca301d5722d443b57ab5fd5db...

Powered by Google App Engine
This is Rietveld 408576698