Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2747423002: Cleanup: Remove LogoBridge instance from NewTabPage (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 3b3bb8822a169659229e92db6f9068fe6a5f8152..e338b426665e8f50e21766f0167f64a064caf8e7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -87,7 +87,6 @@ public class NewTabPage
private final TileGroup.Delegate mTileGroupDelegate;
private TabObserver mTabObserver;
- private LogoBridge mLogoBridge;
Michael van Ouwerkerk 2017/03/15 11:12:07 Thanks Marc! Looks like I missed that when reviewi
private boolean mSearchProviderHasLogo;
private FakeboxDelegate mFakeboxDelegate;
private SnippetsBridge mSnippetsBridge;
@@ -378,7 +377,6 @@ public class NewTabPage
}
};
mTab.addObserver(mTabObserver);
- mLogoBridge = new LogoBridge(profile);
updateSearchProviderHasLogo();
LayoutInflater inflater = LayoutInflater.from(activity);
@@ -561,10 +559,6 @@ public class NewTabPage
.isAttachedToWindow(getView()) : "Destroy called before removed from window";
if (mIsLoaded && !mTab.isHidden()) recordNTPInteractionTime();
- if (mLogoBridge != null) {
- mLogoBridge.destroy();
- mLogoBridge = null;
- }
if (mSnippetsBridge != null) {
mSnippetsBridge.onDestroy();
mSnippetsBridge = null;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698