Make makeSearchRange() in VisibleSelection to handle BeforeAnchor and AfterAnchor position type

Make makeSearchRange() in VisibleSelection to handle BeforeAnchor and AfterAnchor position type

This patch makes |makeSearchRange()| in |VisibleSelection| to use |Position|
container node instead of anchor node to return correct range.

Before this patch, |makeSearchRange()| attempts to create a range from
after element to after child nodes of element which violates |start <= end|
in |EphmeralRange| constructor.

BUG=700368
TEST=run_webkit_unit_tests --gtest_filter=VisibleSelectionTest.appendTrailingWhitespaceWithAfterAnchor

Review-Url: https://codereview.chromium.org/2747333002
Cr-Commit-Position: refs/heads/master@{#457018}
Committed: https://chromium.googlesource.com/chromium/src/+/66986ea643d5a387e1ec0682663617df0cda2b96

[yosin_UTC9, 2017-03-15 02:21:54]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 02:22:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-15 03:54:46]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 03:55:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-15 04:01:27]

Description was changed from

==========
2017-03-15T11:19:42

2017-03-15T11:19:28

BUG=700368
==========

to

==========
Make makeSearchRange() in VisibleSelection to handle BeforeAnchor and
AfterAnchor position type

This patch makes |makeSearchRange()| in |VisibleSelection| to use |Position|
container node instead of anchor node to return correct range.

Before this patch, |makeSearchRange()| attempts to create a range from
after element to after child nodes of element which violates |start <= end|
in |EphmeralRange| constructor.

BUG=700368
TEST=run_webkit_unit_tests
--gtest_filter=VisibleSelectionTest.appendTrailingWhitespaceWithAfterAnchor
==========

[yosin_UTC9, 2017-03-15 04:03:09]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-15 04:03:09]

PTAL

All tests in passed in PS#1 which contains unexpected change in
"VisibleUnits.cpp", just insert an extra blank line.

PS#2 omits "VisibleUnits.cpp".

[tkent, 2017-03-15 04:26:14]

lgtm

[yoichio, 2017-03-15 04:49:29]

https://codereview.chromium.org/2747333002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp (right):

https://codereview.chromium.org/2747333002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp:80: // Simulate
double-clicking "abc"
double-clicking on user-select:none should not select anything.
Could you modify comment more exactly?

[commit-bot: I haz the power, 2017-03-15 05:33:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 05:33:45]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-15 05:34:26]

Thanks for reviewing!

https://codereview.chromium.org/2747333002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp (right):

https://codereview.chromium.org/2747333002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp:80: // Simulate
double-clicking "abc"
On 2017/03/15 at 04:49:29, yoichio wrote:
> double-clicking on user-select:none should not select anything.
> Could you modify comment more exactly?
No, this is current behavior and the test case provided by bug. We compute
unused selection when double-click on user-select:none.
I filed [1] to avoid unused computation of selection in
SelectionController::selectClosestWordFromHitTestResult

[1] http://crbug.com/701657
⚐	SelectionController::selectClosestWordFromHitTestResult should check
user-select:none at beginning of function

[yosin_UTC9, 2017-03-15 05:34:29]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-15 05:34:32]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2747333002/#ps40001
(title: "2017-03-15T14:33:19 Update a comment in test")

[commit-bot: I haz the power, 2017-03-15 05:34:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 07:04:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489556069554520,
"parent_rev": "4d059dcf25a256d591234eb2a7ffd1673f7c9709", "commit_rev":
"66986ea643d5a387e1ec0682663617df0cda2b96"}

[commit-bot: I haz the power, 2017-03-15 07:05:48]

Description was changed from

==========
Make makeSearchRange() in VisibleSelection to handle BeforeAnchor and
AfterAnchor position type

This patch makes |makeSearchRange()| in |VisibleSelection| to use |Position|
container node instead of anchor node to return correct range.

Before this patch, |makeSearchRange()| attempts to create a range from
after element to after child nodes of element which violates |start <= end|
in |EphmeralRange| constructor.

BUG=700368
TEST=run_webkit_unit_tests
--gtest_filter=VisibleSelectionTest.appendTrailingWhitespaceWithAfterAnchor
==========

to

==========
Make makeSearchRange() in VisibleSelection to handle BeforeAnchor and
AfterAnchor position type

This patch makes |makeSearchRange()| in |VisibleSelection| to use |Position|
container node instead of anchor node to return correct range.

Before this patch, |makeSearchRange()| attempts to create a range from
after element to after child nodes of element which violates |start <= end|
in |EphmeralRange| constructor.

BUG=700368
TEST=run_webkit_unit_tests
--gtest_filter=VisibleSelectionTest.appendTrailingWhitespaceWithAfterAnchor

Review-Url: https://codereview.chromium.org/2747333002
Cr-Commit-Position: refs/heads/master@{#457018}
Committed:
https://chromium.googlesource.com/chromium/src/+/66986ea643d5a387e1ec06826636...
==========

[commit-bot: I haz the power, 2017-03-15 07:05:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/66986ea643d5a387e1ec06826636...