Make makeSearchRange() in VisibleSelection to handle BeforeAnchor and AfterAnchor position type

third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/VisibleSelection.h"
 
 #include "core/dom/Range.h"
 #include "core/editing/EditingTestBase.h"
 #include "core/editing/SelectionAdjuster.h"
 
@@ skipping 52 matching lines @@
 VisibleSelectionTemplate<Strategy> expandUsingGranularity(
     const VisibleSelectionTemplate<Strategy>& selection,
     TextGranularity granularity) {
   return createVisibleSelection(
       typename SelectionTemplate<Strategy>::Builder()
           .setBaseAndExtent(selection.base(), selection.extent())
           .setGranularity(granularity)
           .build());
 }
 
+// For http://crbug.com/700368
+TEST_F(VisibleSelectionTest, appendTrailingWhitespaceWithAfterAnchor) {
+  setBodyContent(
+      "<input type=checkbox>"
+      "<div style='user-select:none'>abc</div>");
+  Element* const input = document().querySelector("input");
+
+  // Simulate double-clicking "abc"

[yoichio, 2017/03/15 04:49:29]

double-clicking on user-select:none should not select anything.
Could you modify comment more exactly?

[yosin_UTC9, 2017/03/15 05:34:26]

No, this is current behavior and the test case provided by bug. We compute
unused selection when double-click on user-select:none.
I filed [1] to avoid unused computation of selection in
SelectionController::selectClosestWordFromHitTestResult

[1] http://crbug.com/701657
⚐	SelectionController::selectClosestWordFromHitTestResult should check
user-select:none at beginning of function

+  VisibleSelection selection =
+      createVisibleSelection(SelectionInDOMTree::Builder()
+                                 .collapse(Position::beforeNode(input))
+                                 .extend(Position::afterNode(input))
+                                 .setGranularity(WordGranularity)
+                                 .build());
+  selection.appendTrailingWhitespace();
+
+  EXPECT_EQ(Position::beforeNode(input), selection.start());
+  EXPECT_EQ(Position::afterNode(input), selection.end());
+}
+
 TEST_F(VisibleSelectionTest, expandUsingGranularity) {
   const char* bodyContent =
       "<span id=host><a id=one>1</a><a id=two>22</a></span>";
   const char* shadowContent =
       "<p><b id=three>333</b><content select=#two></content><b "
       "id=four>4444</b><span id=space>  </span><content "
       "select=#one></content><b id=five>55555</b></p>";
   setBodyContent(bodyContent);
   ShadowRoot* shadowRoot = setShadowContent(shadowContent, "host");
 
@@ skipping 425 matching lines @@
   Element* host = document().getElementById("host");
   host->appendChild(sample);
   document().updateStyleAndLayout();
 
   // Simulates to restore selection from undo stack.
   selection = createVisibleSelection(selection.asSelection());
   EXPECT_EQ(Position(sample->firstChild(), 0), selection.start());
 }
 
 }  // namespace blink