Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2747243006: [debug] whitelist Object and Symbol builtins for debug-evaluate. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] whitelist Object and Symbol builtins for debug-evaluate. R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2747243006 Cr-Commit-Position: refs/heads/master@{#43871} Committed: https://chromium.googlesource.com/v8/v8/+/cd640d225b4a179646a8c754e22c592d7d0b5dde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -2 lines) Patch
M src/debug/debug-evaluate.cc View 4 chunks +23 lines, -0 lines 0 comments Download
M test/debugger/debug/debug-evaluate-no-side-effect-builtins.js View 2 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Yang
3 years, 9 months ago (2017-03-16 13:43:15 UTC) #1
jgruber
lgtm
3 years, 9 months ago (2017-03-16 17:02:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747243006/1
3 years, 9 months ago (2017-03-16 17:08:58 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:10:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cd640d225b4a179646a8c754e22c592d7d0...

Powered by Google App Engine
This is Rietveld 408576698