[debug] whitelist Object and Symbol builtins for debug-evaluate.

src/debug/debug-evaluate.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/debug/debug-evaluate.h"
 
 #include "src/accessors.h"
 #include "src/compiler.h"
 #include "src/contexts.h"
 #include "src/debug/debug-frames.h"
@@ skipping 297 matching lines @@
     // Literals.
     case Runtime::kCreateArrayLiteral:
     case Runtime::kCreateObjectLiteral:
     case Runtime::kCreateRegExpLiteral:
     // Misc.
     case Runtime::kForInPrepare:
     case Runtime::kInlineCall:
     case Runtime::kCall:
     case Runtime::kInlineMaxSmi:
     case Runtime::kMaxSmi:
+    case Runtime::kHasInPrototypeChain:
       return true;
     default:
       if (FLAG_trace_side_effect_free_debug_evaluate) {
         PrintF("[debug-evaluate] intrinsic %s may cause side effect.\n",
                Runtime::FunctionForId(id)->name);
       }
       return false;
   }
 }
 
@@ skipping 44 matching lines @@
     // Literals.
     case Bytecode::kCreateArrayLiteral:
     case Bytecode::kCreateObjectLiteral:
     case Bytecode::kCreateRegExpLiteral:
     // Allocations.
     case Bytecode::kCreateClosure:
     case Bytecode::kCreateUnmappedArguments:
     // Conversions.
     case Bytecode::kToObject:
     case Bytecode::kToNumber:
+    case Bytecode::kToName:
     // Misc.
     case Bytecode::kForInPrepare:
     case Bytecode::kForInContinue:
     case Bytecode::kForInNext:
     case Bytecode::kForInStep:
     case Bytecode::kThrow:
     case Bytecode::kReThrow:
     case Bytecode::kIllegal:
     case Bytecode::kCallJSRuntime:
     case Bytecode::kStackCheck:
     case Bytecode::kReturn:
     case Bytecode::kSetPendingMessage:
       return true;
     default:
       if (FLAG_trace_side_effect_free_debug_evaluate) {
         PrintF("[debug-evaluate] bytecode %s may cause side effect.\n",
                Bytecodes::ToString(bytecode));
       }
       return false;
   }
 }
 
 bool BuiltinHasNoSideEffect(Builtins::Name id) {
   switch (id) {
     // Whitelist for builtins.
     // Object builtins.
+    case Builtins::kObjectCreate:
+    case Builtins::kObjectEntries:
+    case Builtins::kObjectGetOwnPropertyDescriptor:
+    case Builtins::kObjectGetOwnPropertyDescriptors:
+    case Builtins::kObjectGetOwnPropertyNames:
+    case Builtins::kObjectGetOwnPropertySymbols:
+    case Builtins::kObjectGetPrototypeOf:
+    case Builtins::kObjectIs:
+    case Builtins::kObjectIsExtensible:
+    case Builtins::kObjectIsFrozen:
+    case Builtins::kObjectIsSealed:
     case Builtins::kObjectPrototypeValueOf:
+    case Builtins::kObjectValues:
+    case Builtins::kObjectHasOwnProperty:
+    case Builtins::kObjectPrototypePropertyIsEnumerable:
+    case Builtins::kObjectProtoToString:
     // Array builtins.
     case Builtins::kArrayCode:
     case Builtins::kArrayIndexOf:
     case Builtins::kArrayPrototypeValues:
     case Builtins::kArrayIncludes:
     case Builtins::kArrayPrototypeEntries:
     case Builtins::kArrayPrototypeKeys:
     case Builtins::kArrayForEach:
     case Builtins::kArrayEvery:
     case Builtins::kArraySome:
@@ skipping 59 matching lines @@
     case Builtins::kStringPrototypeStartsWith:
     case Builtins::kStringPrototypeSubstr:
     case Builtins::kStringPrototypeSubstring:
     case Builtins::kStringPrototypeToString:
     case Builtins::kStringPrototypeToLowerCase:
     case Builtins::kStringPrototypeToUpperCase:
     case Builtins::kStringPrototypeTrim:
     case Builtins::kStringPrototypeTrimLeft:
     case Builtins::kStringPrototypeTrimRight:
     case Builtins::kStringPrototypeValueOf:
+    // Symbol builtins.
+    case Builtins::kSymbolConstructor:
+    case Builtins::kSymbolKeyFor:
+    case Builtins::kSymbolPrototypeToString:
+    case Builtins::kSymbolPrototypeValueOf:
+    case Builtins::kSymbolPrototypeToPrimitive:
     // JSON builtins.
     case Builtins::kJsonParse:
     case Builtins::kJsonStringify:
     // Error builtins.
     case Builtins::kMakeError:
     case Builtins::kMakeTypeError:
     case Builtins::kMakeSyntaxError:
     case Builtins::kMakeRangeError:
     case Builtins::kMakeURIError:
       return true;
@@ skipping 70 matching lines @@
 
   if (FLAG_trace_side_effect_free_debug_evaluate) {
     PrintF("[debug-evaluate] API Callback at %p may cause side effect.\n",
            reinterpret_cast<void*>(function_addr));
   }
   return false;
 }
 
 }  // namespace internal
 }  // namespace v8