Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2747173003: UKM: log PageTransition and failed provisional load info (Closed)

Created:
3 years, 9 months ago by Bryan McQuade
Modified:
3 years, 9 months ago
Reviewers:
bengr, RyanSturm
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, rkaplow, speed-metrics-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UKM: log PageTransition and failed provisional load info BUG=701372 Review-Url: https://codereview.chromium.org/2747173003 Cr-Commit-Position: refs/heads/master@{#456863} Committed: https://chromium.googlesource.com/chromium/src/+/bdf4447c2b53c291b12eed74bad3bc0aa3c63eff

Patch Set 1 #

Patch Set 2 : remove unnecessary include #

Patch Set 3 : log positive values for net error codes #

Patch Set 4 : naming fix #

Patch Set 5 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h View 1 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc View 1 2 3 4 4 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc View 1 2 3 chunks +65 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
Bryan McQuade
PTAL, thanks!
3 years, 9 months ago (2017-03-14 15:06:12 UTC) #6
Bryan McQuade
adding ryansturm as additional reviewer. PTAL, thanks!
3 years, 9 months ago (2017-03-14 20:20:47 UTC) #16
bengr
lgtm
3 years, 9 months ago (2017-03-14 20:29:28 UTC) #17
RyanSturm
lgtm
3 years, 9 months ago (2017-03-14 20:36:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747173003/80001
3 years, 9 months ago (2017-03-14 22:08:51 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 22:20:10 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/bdf4447c2b53c291b12eed74bad3...

Powered by Google App Engine
This is Rietveld 408576698