Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

Issue 2747173003: UKM: log PageTransition and failed provisional load info (Closed)
Patch Set: fix comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
index 16dfbbbbc1898279ab08cb303c32a8c0fec1e93c..6b165925a225b2787743c681939652a561d399cc 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
@@ -8,6 +8,7 @@
#include "base/macros.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
#include "net/nqe/network_quality_estimator.h"
+#include "ui/base/page_transition_types.h"
namespace content {
class WebContents;
@@ -23,7 +24,10 @@ extern const char kUkmLoadEventName[];
extern const char kUkmFirstContentfulPaintName[];
extern const char kUkmFirstMeaningfulPaintName[];
extern const char kUkmForegroundDurationName[];
+extern const char kUkmFailedProvisionaLoadName[];
+extern const char kUkmNetErrorCode[];
extern const char kUkmEffectiveConnectionType[];
+extern const char kUkmPageTransition[];
} // namespace internal
@@ -46,6 +50,8 @@ class UkmPageLoadMetricsObserver
const GURL& currently_committed_url,
bool started_in_foreground) override;
+ ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
+
ObservePolicy FlushMetricsOnAppEnterBackground(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
@@ -82,6 +88,9 @@ class UkmPageLoadMetricsObserver
net::EffectiveConnectionType effective_connection_type_ =
net::EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
+ // PAGE_TRANSITION_LINK is the default PageTransition value.
+ ui::PageTransition page_transition_ = ui::PAGE_TRANSITION_LINK;
+
DISALLOW_COPY_AND_ASSIGN(UkmPageLoadMetricsObserver);
};
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698