Handle 'part of' declarations with URI correctly in Fasta.

Handle 'part of' declarations with URI correctly in Fasta.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/99fa028982e77b83e91bc0ad29d06fc51b42ad37

[ahe, 2017-03-14 14:14:02]

ahe@google.com changed reviewers:
+ paulberry@google.com

[ahe, 2017-03-14 14:14:03]

Paul: this is the CL where "part of" declarations and skipping. But as you can
see, I solved the problem by adding an additional parameter to the part-of
event.

[ahe, 2017-03-14 14:14:31]

On 2017/03/14 14:14:03, ahe wrote:
> Paul: this is the CL where "part of" declarations and skipping

interact.

[Paul Berry, 2017-03-14 14:48:23]

lgtm

https://codereview.chromium.org/2747173002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/outline_builder.dart (right):

https://codereview.chromium.org/2747173002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/outline_builder.dart:581: String name =
hasName ? pop() : null;
I see what you're doing here, but IMHO it's a little hard to follow.  Consider
doing this instead:

String containingLib = pop();
List<MetadataBuilder> metadata = pop();
if (hasName) {
  library.addPartOf(metadata, containingLib, null);
} else {
  library.addPartOf(metadata, null, containingLib);
}

[ahe, 2017-03-15 14:05:36]

Thank you, Paul!

https://codereview.chromium.org/2747173002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/outline_builder.dart (right):

https://codereview.chromium.org/2747173002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/outline_builder.dart:581: String name =
hasName ? pop() : null;
On 2017/03/14 14:48:23, Paul Berry wrote:
> I see what you're doing here, but IMHO it's a little hard to follow.  Consider
> doing this instead:
> 
> String containingLib = pop();
> List<MetadataBuilder> metadata = pop();
> if (hasName) {
>   library.addPartOf(metadata, containingLib, null);
> } else {
>   library.addPartOf(metadata, null, containingLib);
> }

Honestly, I wasn't super happy with it either :-)

[ahe, 2017-03-15 14:11:43]

Description was changed from

==========
Handle 'part of' declarations with URI correctly in Fasta.
==========

to

==========
Handle 'part of' declarations with URI correctly in Fasta.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/99fa028982e77b83e91bc0ad29d06fc51b42ad37
==========

[ahe, 2017-03-15 14:11:45]

Committed patchset #3 (id:40001) manually as
99fa028982e77b83e91bc0ad29d06fc51b42ad37 (presubmit successful).