Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2747173002: Handle 'part of' declarations with URI correctly in Fasta. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
index 15a24a74dbcfbb88fdd7f5bd612c226187aa11cd..3e4b7f152cd6af9d4dd8e2dae099c2f12218fde6 100644
--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
@@ -576,11 +576,15 @@ class OutlineBuilder extends UnhandledListener {
}
@override
- void endPartOf(Token partKeyword, Token semicolon) {
+ void endPartOf(Token partKeyword, Token semicolon, bool hasName) {
debugEvent("endPartOf");
- String name = pop();
+ String containingLibrary = pop();
List<MetadataBuilder> metadata = pop();
- library.addPartOf(metadata, name);
+ if (hasName) {
+ library.addPartOf(metadata, containingLibrary, null);
+ } else {
+ library.addPartOf(metadata, null, containingLibrary);
+ }
}
@override
« no previous file with comments | « pkg/front_end/lib/src/fasta/source/diet_listener.dart ('k') | pkg/front_end/lib/src/fasta/source/source_library_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698