Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2746763003: Add default type arguments on Supertype as well. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on 1cb1b70d5daf9ec7f24a98be9d2fdac919ae0c24. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -30 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_builder.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 1 chunk +18 lines, -25 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
ahe
3 years, 9 months ago (2017-03-13 14:53:20 UTC) #3
karlklose
LGTM
3 years, 9 months ago (2017-03-15 12:06:35 UTC) #4
ahe
3 years, 9 months ago (2017-03-15 13:05:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
626987ef5c64e8818deadbf1aacf99bd615cc4e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698