Dirty pres. attribute style on <svg> dimension change when not attached

Dirty pres. attribute style on <svg> dimension change when not attached

When an <svg> wasn't attached, and it had its 'width'/'height' mutated
via the SVG DOM interfaces (SVG*Length), presentation attribute style
would not be dirtied. This could lead to an incorrect size being
computed in some cases.
Ensure that presentation attribute style is always updated if the <svg>
element is not attached.

BUG=701075
Review-Url: https://codereview.chromium.org/2747153002
Cr-Commit-Position: refs/heads/master@{#456702}
Committed: https://chromium.googlesource.com/chromium/src/+/b4ea1268734a32066e965107a5bb0d3ac7cba5a1

[fs, 2017-03-14 12:48:18]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 12:48:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-03-14 12:49:05]

Description was changed from

==========
Dirty presentation attribute style on <svg> 'width' when not attached

When an <svg> wasn'ty attached, and it had its 'width'/'height' mutated
via the SVG DOM interfaces (SVG*Length), presentation attribute style
would not be dirtied. This could lead to an incorrect size being
computed in some cases.
Ensure that presentation attribute style is always updated if the <svg>
element is not attached.

BUG=701075
==========

to

==========
Dirty pres. attribute style on <svg> dimension change when not attached

When an <svg> wasn'ty attached, and it had its 'width'/'height' mutated
via the SVG DOM interfaces (SVG*Length), presentation attribute style
would not be dirtied. This could lead to an incorrect size being
computed in some cases.
Ensure that presentation attribute style is always updated if the <svg>
element is not attached.

BUG=701075
==========

[fs, 2017-03-14 13:45:48]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[fs, 2017-03-14 13:45:49]

Found when auditing the code for cases similar to
https://codereview.chromium.org/2745053005.

[Stephen Chennney, 2017-03-14 14:09:07]

lgtm.

I wonder if this is the cause of some of our "SVG does not appear" issues, that
I always assumed were scheduling related.

[fs, 2017-03-14 14:11:28]

On 2017/03/14 at 14:09:07, schenney wrote:
> lgtm.
> 
> I wonder if this is the cause of some of our "SVG does not appear" issues,
that I always assumed were scheduling related.

I don't know, but I would expect not. (The parameters required for this to be
hit are not what I would expect to see in the large majority of real-world
content.)

[commit-bot: I haz the power, 2017-03-14 14:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 14:18:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-03-14 14:19:08]

The CQ bit was checked by fs@opera.com

[fs, 2017-03-14 14:19:24]

The CQ bit was unchecked by fs@opera.com

[commit-bot: I haz the power, 2017-03-14 14:19:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-03-14 14:19:44]

Description was changed from

==========
Dirty pres. attribute style on <svg> dimension change when not attached

When an <svg> wasn'ty attached, and it had its 'width'/'height' mutated
via the SVG DOM interfaces (SVG*Length), presentation attribute style
would not be dirtied. This could lead to an incorrect size being
computed in some cases.
Ensure that presentation attribute style is always updated if the <svg>
element is not attached.

BUG=701075
==========

to

==========
Dirty pres. attribute style on <svg> dimension change when not attached

When an <svg> wasn't attached, and it had its 'width'/'height' mutated
via the SVG DOM interfaces (SVG*Length), presentation attribute style
would not be dirtied. This could lead to an incorrect size being
computed in some cases.
Ensure that presentation attribute style is always updated if the <svg>
element is not attached.

BUG=701075
==========

[commit-bot: I haz the power, 2017-03-14 14:56:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489501148723880, "parent_rev":
"df3e4b2a5dbc59b8707015f1a10492202ff47a1b", "commit_rev":
"b4ea1268734a32066e965107a5bb0d3ac7cba5a1"}

[commit-bot: I haz the power, 2017-03-14 14:57:36]

Description was changed from

==========
Dirty pres. attribute style on <svg> dimension change when not attached

When an <svg> wasn't attached, and it had its 'width'/'height' mutated
via the SVG DOM interfaces (SVG*Length), presentation attribute style
would not be dirtied. This could lead to an incorrect size being
computed in some cases.
Ensure that presentation attribute style is always updated if the <svg>
element is not attached.

BUG=701075
==========

to

==========
Dirty pres. attribute style on <svg> dimension change when not attached

When an <svg> wasn't attached, and it had its 'width'/'height' mutated
via the SVG DOM interfaces (SVG*Length), presentation attribute style
would not be dirtied. This could lead to an incorrect size being
computed in some cases.
Ensure that presentation attribute style is always updated if the <svg>
element is not attached.

BUG=701075

Review-Url: https://codereview.chromium.org/2747153002
Cr-Commit-Position: refs/heads/master@{#456702}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4ea1268734a32066e965107a5bb...
==========

[commit-bot: I haz the power, 2017-03-14 14:57:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4ea1268734a32066e965107a5bb...