Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2747153002: Dirty pres. attribute style on <svg> dimension change when not attached (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dirty pres. attribute style on <svg> dimension change when not attached When an <svg> wasn't attached, and it had its 'width'/'height' mutated via the SVG DOM interfaces (SVG*Length), presentation attribute style would not be dirtied. This could lead to an incorrect size being computed in some cases. Ensure that presentation attribute style is always updated if the <svg> element is not attached. BUG=701075 Review-Url: https://codereview.chromium.org/2747153002 Cr-Commit-Position: refs/heads/master@{#456702} Committed: https://chromium.googlesource.com/chromium/src/+/b4ea1268734a32066e965107a5bb0d3ac7cba5a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/svg/custom/svgdom-manipulation-of-svg-root-width-before-attach.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/svgdom-manipulation-of-svg-root-width-before-attach-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
fs
Found when auditing the code for cases similar to https://codereview.chromium.org/2745053005.
3 years, 9 months ago (2017-03-14 13:45:49 UTC) #5
Stephen Chennney
lgtm. I wonder if this is the cause of some of our "SVG does not ...
3 years, 9 months ago (2017-03-14 14:09:07 UTC) #6
fs
On 2017/03/14 at 14:09:07, schenney wrote: > lgtm. > > I wonder if this is ...
3 years, 9 months ago (2017-03-14 14:11:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747153002/1
3 years, 9 months ago (2017-03-14 14:19:24 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 14:57:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4ea1268734a32066e965107a5bb...

Powered by Google App Engine
This is Rietveld 408576698