Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2747143004: Eagerly invalidate when a layer becomes stacking context (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Eagerly invalidate when a layer becomes stacking context When an object begin or cease to be a stacking context, the paint invalidation container of the object and/or descendants may change. We need to invalidate paint eagerly for all such children. PaintLayerCompositor::paintInvalidationOnCompositingChange() doesn't work for the case because it can only see the new paintInvalidationContainer. Previously we handled the case of ceasing to be stacking context only. BUG=688647 TEST=paint/invalidation/compositing/new-stacking-context.html TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2738303002 Cr-Original-Commit-Position: refs/heads/master@{#456277} Review-Url: https://codereview.chromium.org/2747143004 Cr-Commit-Position: refs/branch-heads/3029@{#186} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b6d4dbd30650860f7cd2110626337ee041e7e7aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+889 lines, -53 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/change-transform-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/containing-block-added-expected.txt View 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/invalidate-when-leaving-squashed-layer-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context-expected.txt View 2 chunks +35 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/css-grid-layout/grid-item-z-index-change-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-after-scroll-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-position-transparency-with-overflow-expected.txt View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/flexbox/repaint-opacity-change-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/invalidate-descendants-when-receiving-paint-layer-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/mix-blend-mode-separate-stacking-context-expected.txt View 3 chunks +27 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/paint-invalidation-with-opacity-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/scroll-fixed-reflected-layer-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/scroll-in-transformed-layer-expected.txt View 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/transform-foreign-object-expected.txt View 2 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/transform-text-element-expected.txt View 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/create-layer-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll-descendant-with-cached-cliprects-expected.txt View 2 chunks +21 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/tabgroup-expected.txt View 2 chunks +160 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-repaint-including-stroke-expected.txt View 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/transform-inline-layered-child-expected.txt View 2 chunks +94 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/scroll-descendant-with-cached-cliprects-expected.txt View 2 chunks +20 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/tabgroup-expected.txt View 2 chunks +160 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/text-repaint-including-stroke-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 2 chunks +97 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/scroll-in-transformed-layer-expected.txt View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/transform-foreign-object-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/svg/transform-text-element-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747143004/1
3 years, 9 months ago (2017-03-14 16:16:43 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:20:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6d4dbd30650860f7cd211062633...

Powered by Google App Engine
This is Rietveld 408576698