Eagerly invalidate when a layer becomes stacking context

Eagerly invalidate when a layer becomes stacking context

When an object begin or cease to be a stacking context, the paint
invalidation container of the object and/or descendants may change.
We need to invalidate paint eagerly for all such children.
PaintLayerCompositor::paintInvalidationOnCompositingChange() doesn't
work for the case because it can only see the new
paintInvalidationContainer.

Previously we handled the case of ceasing to be stacking context only.

BUG=688647
TEST=paint/invalidation/compositing/new-stacking-context.html

Review-Url: https://codereview.chromium.org/2738303002
Cr-Commit-Position: refs/heads/master@{#456277}
Committed: https://chromium.googlesource.com/chromium/src/+/0c449aad3898922b599d8a32c2380cc8c962040e

[Xianzhu, 2017-03-09 21:30:16]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 21:30:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-03-09 21:36:54]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[Xianzhu, 2017-03-09 21:36:54]

https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context.html
(right):

https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context.html:16:
</div>
This test is not created as a ref test because I couldn't create an HTML file
which has enough difference from the test and creates the exact pixels. The
following HTML creates a visually equivalent result to my eyes but there is tiny
difference in the color of the translucent green box:
<div style="width: 100px; height: 100px; opacity: 0.5; background: green"></div>

[wkorman, 2017-03-10 23:38:09]

lgtm

https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:110: crbug.com/688647
paint/invalidation/transform-inline-layered-child.html [ NeedsRebaseline ]
Can you try using rebaseline-cl for this change? If any issues keep notes and
file on qyearsley@. We have addressed many of the issues that have made it
problematic in past.

https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context.html
(right):

https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context.html:16:
</div>
On 2017/03/09 21:36:54, Xianzhu wrote:
> This test is not created as a ref test because I couldn't create an HTML file
> which has enough difference from the test and creates the exact pixels. The
> following HTML creates a visually equivalent result to my eyes but there is
tiny
> difference in the color of the translucent green box:
> <div style="width: 100px; height: 100px; opacity: 0.5; background:
green"></div>

Acknowledged.

[Xianzhu, 2017-03-11 00:28:02]

On 2017/03/10 23:38:09, wkorman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/TestExpectations:110: crbug.com/688647
> paint/invalidation/transform-inline-layered-child.html [ NeedsRebaseline ]
> Can you try using rebaseline-cl for this change? If any issues keep notes and
> file on qyearsley@. We have addressed many of the issues that have made it
> problematic in past.

For now rebaseline-cl is blocked by crbug.com/700523
 
> 
>
https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context.html
> (right):
> 
>
https://codereview.chromium.org/2738303002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/paint/invalidation/compositing/new-stacking-context.html:16:
> </div>
> On 2017/03/09 21:36:54, Xianzhu wrote:
> > This test is not created as a ref test because I couldn't create an HTML
file
> > which has enough difference from the test and creates the exact pixels. The
> > following HTML creates a visually equivalent result to my eyes but there is
> tiny
> > difference in the color of the translucent green box:
> > <div style="width: 100px; height: 100px; opacity: 0.5; background:
> green"></div>
> 
> Acknowledged.

[Xianzhu, 2017-03-11 00:28:11]

Patchset #3 (id:40001) has been deleted

[Xianzhu, 2017-03-11 00:28:14]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-11 00:28:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 01:51:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 01:52:00]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-03-11 02:37:16]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-11 02:37:16]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2738303002/#ps60001
(title: "Rebaseline")

[commit-bot: I haz the power, 2017-03-11 02:37:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 04:09:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489199836179140,
"parent_rev": "c4da9f64b553a9355093a6455cc7e49b3cc7f980", "commit_rev":
"0c449aad3898922b599d8a32c2380cc8c962040e"}

[commit-bot: I haz the power, 2017-03-11 04:11:17]

Description was changed from

==========
Eagerly invalidate when a layer becomes stacking context

When an object begin or cease to be a stacking context, the paint
invalidation container of the object and/or descendants may change.
We need to invalidate paint eagerly for all such children.
PaintLayerCompositor::paintInvalidationOnCompositingChange() doesn't
work for the case because it can only see the new
paintInvalidationContainer.

Previously we handled the case of ceasing to be stacking context only.

BUG=688647
TEST=paint/invalidation/compositing/new-stacking-context.html
==========

to

==========
Eagerly invalidate when a layer becomes stacking context

When an object begin or cease to be a stacking context, the paint
invalidation container of the object and/or descendants may change.
We need to invalidate paint eagerly for all such children.
PaintLayerCompositor::paintInvalidationOnCompositingChange() doesn't
work for the case because it can only see the new
paintInvalidationContainer.

Previously we handled the case of ceasing to be stacking context only.

BUG=688647
TEST=paint/invalidation/compositing/new-stacking-context.html

Review-Url: https://codereview.chromium.org/2738303002
Cr-Commit-Position: refs/heads/master@{#456277}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c449aad3898922b599d8a32c238...
==========

[commit-bot: I haz the power, 2017-03-11 04:11:18]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0c449aad3898922b599d8a32c238...