Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2746873003: Refactor PanelLayoutManager to use aura::LayoutManager (Closed)

Created:
3 years, 9 months ago by yiyix
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor PanelLayoutManager to use aura::LayoutManager BUG=687657 Review-Url: https://codereview.chromium.org/2746873003 Cr-Commit-Position: refs/heads/master@{#457090} Committed: https://chromium.googlesource.com/chromium/src/+/9f084ef51daaddb8a090d865dfc904ca1b8335a0

Patch Set 1 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -55 lines) Patch
M ash/common/wm/panels/panel_layout_manager.h View 3 chunks +15 lines, -14 lines 0 comments Download
M ash/common/wm/panels/panel_layout_manager.cc View 6 chunks +38 lines, -32 lines 0 comments Download
M ash/common/wm/wm_snap_to_pixel_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/wm_window_test_api.h View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 51 (47 generated)
yiyix
@sky, could you please review this patch? Thank you.
3 years, 9 months ago (2017-03-15 06:28:05 UTC) #44
sky
LGTM
3 years, 9 months ago (2017-03-15 15:23:59 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746873003/160001
3 years, 9 months ago (2017-03-15 15:32:46 UTC) #47
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 15:37:40 UTC) #50
Message was sent while issue was closed.
Committed patchset #1 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/9f084ef51daaddb8a090d865dfc9...

Powered by Google App Engine
This is Rietveld 408576698