Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: ash/common/wm/wm_snap_to_pixel_layout_manager.cc

Issue 2746873003: Refactor PanelLayoutManager to use aura::LayoutManager (Closed)
Patch Set: minor Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/wm/panels/panel_layout_manager.cc ('k') | ash/root_window_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/wm/wm_snap_to_pixel_layout_manager.h" 5 #include "ash/common/wm/wm_snap_to_pixel_layout_manager.h"
6 6
7 #include "ash/common/wm_window.h" 7 #include "ash/common/wm_window.h"
8 #include "ash/public/cpp/shell_window_ids.h" 8 #include "ash/public/cpp/shell_window_ids.h"
9 #include "ash/wm/window_properties.h" 9 #include "ash/wm/window_properties.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "ui/aura/window.h" 11 #include "ui/aura/window.h"
12 12
13 namespace ash { 13 namespace ash {
14 namespace wm { 14 namespace wm {
15 15
16 WmSnapToPixelLayoutManager::WmSnapToPixelLayoutManager() {} 16 WmSnapToPixelLayoutManager::WmSnapToPixelLayoutManager() {}
17 17
18 WmSnapToPixelLayoutManager::~WmSnapToPixelLayoutManager() {} 18 WmSnapToPixelLayoutManager::~WmSnapToPixelLayoutManager() {}
19 19
20 // static 20 // static
21 void WmSnapToPixelLayoutManager::InstallOnContainers(WmWindow* window) { 21 void WmSnapToPixelLayoutManager::InstallOnContainers(WmWindow* window) {
22 for (WmWindow* child : window->GetChildren()) { 22 for (WmWindow* child : window->GetChildren()) {
23 if (child->GetShellWindowId() < kShellWindowId_Min || 23 if (child->GetShellWindowId() < kShellWindowId_Min ||
24 child->GetShellWindowId() > kShellWindowId_Max) // not a container 24 child->GetShellWindowId() > kShellWindowId_Max) // not a container
25 continue; 25 continue;
26 if (child->aura_window()->GetProperty(kSnapChildrenToPixelBoundary)) { 26 if (child->aura_window()->GetProperty(kSnapChildrenToPixelBoundary)) {
27 if (!child->GetLayoutManager()) 27 if (!child->GetLayoutManager() && !child->aura_window()->layout_manager())
28 child->SetLayoutManager(base::MakeUnique<WmSnapToPixelLayoutManager>()); 28 child->SetLayoutManager(base::MakeUnique<WmSnapToPixelLayoutManager>());
29 } else { 29 } else {
30 InstallOnContainers(child); 30 InstallOnContainers(child);
31 } 31 }
32 } 32 }
33 } 33 }
34 34
35 void WmSnapToPixelLayoutManager::OnWindowResized() {} 35 void WmSnapToPixelLayoutManager::OnWindowResized() {}
36 36
37 void WmSnapToPixelLayoutManager::OnWindowAddedToLayout(WmWindow* child) {} 37 void WmSnapToPixelLayoutManager::OnWindowAddedToLayout(WmWindow* child) {}
38 38
39 void WmSnapToPixelLayoutManager::OnWillRemoveWindowFromLayout(WmWindow* child) { 39 void WmSnapToPixelLayoutManager::OnWillRemoveWindowFromLayout(WmWindow* child) {
40 } 40 }
41 41
42 void WmSnapToPixelLayoutManager::OnWindowRemovedFromLayout(WmWindow* child) {} 42 void WmSnapToPixelLayoutManager::OnWindowRemovedFromLayout(WmWindow* child) {}
43 43
44 void WmSnapToPixelLayoutManager::OnChildWindowVisibilityChanged(WmWindow* child, 44 void WmSnapToPixelLayoutManager::OnChildWindowVisibilityChanged(WmWindow* child,
45 bool visibile) { 45 bool visibile) {
46 } 46 }
47 47
48 void WmSnapToPixelLayoutManager::SetChildBounds( 48 void WmSnapToPixelLayoutManager::SetChildBounds(
49 WmWindow* child, 49 WmWindow* child,
50 const gfx::Rect& requested_bounds) { 50 const gfx::Rect& requested_bounds) {
51 child->SetBoundsDirect(requested_bounds); 51 child->SetBoundsDirect(requested_bounds);
52 child->SnapToPixelBoundaryIfNecessary(); 52 child->SnapToPixelBoundaryIfNecessary();
53 } 53 }
54 54
55 } // namespace wm 55 } // namespace wm
56 } // namespace ash 56 } // namespace ash
OLDNEW
« no previous file with comments | « ash/common/wm/panels/panel_layout_manager.cc ('k') | ash/root_window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698