Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2746853002: Change MediaStreamDevicesController::RequestPermissions to use the requesting WebContents (Closed)

Created:
3 years, 9 months ago by raymes
Modified:
3 years, 8 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, Matt Giuca, chfremer+watch_chromium.org, achuith+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, tfarina, phoglund+watch_chromium.org, davemoore+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change MediaStreamDevicesController::RequestPermissions to use the requesting WebContents This changes MediaStreamDevicesController::RequestPermissions to use the WebContents associated with the RenderFrameHost specified in the request. This is important because we will be switching RequestPermissions to call into PermissionManager::GetPermissionStatus and PermissionManager::RequestPermissions which will take a RenderFrameHost and not a WebContents. Some tests are fixed to work correctly. BUG=596786 Review-Url: https://codereview.chromium.org/2746853002 Cr-Commit-Position: refs/heads/master@{#463467} Committed: https://chromium.googlesource.com/chromium/src/+/3bc708ecbaf8b268843a706e50de59a7bc7905f2

Patch Set 1 #

Patch Set 2 : Change MediaStreamDevicesController::RequestPermissions to use the requesting WebContents #

Patch Set 3 : Change MediaStreamDevicesController::RequestPermissions to use the requesting WebContents #

Patch Set 4 : Change MediaStreamDevicesController::RequestPermissions to use the requesting WebContents #

Patch Set 5 : Change MediaStreamDevicesController::RequestPermissions to use the requesting WebContents #

Patch Set 6 : Change MediaStreamDevicesController::RequestPermissions to use the requesting WebContents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -24 lines) Patch
M chrome/browser/media/webrtc/media_stream_devices_controller.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc View 1 2 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_request_manager_browsertest.cc View 1 2 3 4 5 4 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 chunks +26 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 29 (22 generated)
raymes
3 years, 9 months ago (2017-03-14 04:27:46 UTC) #2
Timothy Loh
On 2017/03/14 04:27:46, raymes wrote: lgtm
3 years, 9 months ago (2017-03-16 04:59:37 UTC) #3
raymes
+OWNERS sergeyu for chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc pastarmovj for chrome/browser/policy/policy_browsertest.cc
3 years, 8 months ago (2017-04-10 00:35:36 UTC) #7
pastarmovj
policy lgtm
3 years, 8 months ago (2017-04-10 08:13:40 UTC) #14
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-10 18:48:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746853002/90001
3 years, 8 months ago (2017-04-11 00:24:19 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 00:39:25 UTC) #29
Message was sent while issue was closed.
Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/3bc708ecbaf8b268843a706e50de...

Powered by Google App Engine
This is Rietveld 408576698