Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker (Closed)
Patch Set: Rebase and address falken, leon and mek's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.h
diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h
index 5385b98d16a2cb5168cacccff78f17eb17033c4b..9c01bac803dc9bd1e42472cee4b032e4e7857aa6 100644
--- a/content/renderer/service_worker/service_worker_context_client.h
+++ b/content/renderer/service_worker/service_worker_context_client.h
@@ -224,6 +224,9 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
const ServiceWorkerVersionAttributes& attrs);
// mojom::ServiceWorkerEventDispatcher
+ void DispatchInstallEvent(
+ mojom::InstallEventMethodAssociatedPtrInfo client,
+ const DispatchInstallEventCallback& callback) override;
void DispatchActivateEvent(
const DispatchActivateEventCallback& callback) override;
void DispatchBackgroundFetchAbortEvent(
@@ -271,7 +274,6 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
const DispatchPaymentRequestEventCallback& callback) override;
void Ping(const PingCallback& callback) override;
- void OnInstallEvent(int request_id);
void OnNotificationClickEvent(
int request_id,
const std::string& notification_id,
@@ -332,6 +334,9 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
// This is bound on the worker thread.
mojom::ServiceWorkerEventDispatcherRequest pending_dispatcher_request_;
+ // The destination for the install event method.
+ mojom::InstallEventMethodAssociatedPtr install_method_client_;
shimazu 2017/04/05 05:01:27 I think you are trying to have the method interfac
+
// Renderer-side object corresponding to WebEmbeddedWorkerInstance.
// This is valid from the ctor to workerContextDestroyed.
std::unique_ptr<EmbeddedWorkerInstanceClientImpl> embedded_worker_client_;

Powered by Google App Engine
This is Rietveld 408576698