[ServiceWorker] Mojofy InstallEvent of Service Worker

content/renderer/service_worker/service_worker_context_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CLIENT_H_
 #define CONTENT_RENDERER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CLIENT_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 206 matching lines @@
   // in the browser process.
   int GetRoutingID() const { return embedded_worker_id_; }
 
   void Send(IPC::Message* message);
   void SendWorkerStarted();
   void SetRegistrationInServiceWorkerGlobalScope(
       const ServiceWorkerRegistrationObjectInfo& info,
       const ServiceWorkerVersionAttributes& attrs);
 
   // mojom::ServiceWorkerEventDispatcher
+  void DispatchInstallEvent(
+      mojom::InstallEventMethodAssociatedPtrInfo client,
+      const DispatchInstallEventCallback& callback) override;
   void DispatchActivateEvent(
       const DispatchActivateEventCallback& callback) override;
   void DispatchBackgroundFetchAbortEvent(
       const std::string& tag,
       const DispatchBackgroundFetchAbortEventCallback& callback) override;
   void DispatchBackgroundFetchClickEvent(
       const std::string& tag,
       mojom::BackgroundFetchState state,
       const DispatchBackgroundFetchClickEventCallback& callback) override;
   void DispatchBackgroundFetchFailEvent(
@@ skipping 27 matching lines @@
       const std::string& tag,
       blink::mojom::BackgroundSyncEventLastChance last_chance,
       const DispatchSyncEventCallback& callback) override;
   void DispatchPaymentRequestEvent(
       int payment_request_id,
       payments::mojom::PaymentAppRequestPtr app_request,
       payments::mojom::PaymentAppResponseCallbackPtr response_callback,
       const DispatchPaymentRequestEventCallback& callback) override;
   void Ping(const PingCallback& callback) override;
 
-  void OnInstallEvent(int request_id);
   void OnNotificationClickEvent(
       int request_id,
       const std::string& notification_id,
       const PlatformNotificationData& notification_data,
       int action_index,
       const base::NullableString16& reply);
   void OnNotificationCloseEvent(
       int request_id,
       const std::string& notification_id,
       const PlatformNotificationData& notification_data);
@@ skipping 40 matching lines @@
   scoped_refptr<base::TaskRunner> worker_task_runner_;
 
   scoped_refptr<ServiceWorkerProviderContext> provider_context_;
 
   // Not owned; this object is destroyed when proxy_ becomes invalid.
   blink::WebServiceWorkerContextProxy* proxy_;
 
   // This is bound on the worker thread.
   mojom::ServiceWorkerEventDispatcherRequest pending_dispatcher_request_;
 
+  // The destination for the install event method.
+  mojom::InstallEventMethodAssociatedPtr install_method_client_;

[shimazu, 2017/04/05 05:01:27]

I think you are trying to have the method interface for each event. In this
case, each interface pointers passed through DispatchSomeEvent should be kept by
each event instead of directly owned by SWContextClient. I mean it should be
mapped to each event id. For implementation, you might add the event_id to the
ctor of InstallEvent in blink to return the id back to SWContextClient when
registerForeignFetchScopes is called.

+
   // Renderer-side object corresponding to WebEmbeddedWorkerInstance.
   // This is valid from the ctor to workerContextDestroyed.
   std::unique_ptr<EmbeddedWorkerInstanceClientImpl> embedded_worker_client_;
 
   // Initialized on the worker thread in workerContextStarted and
   // destructed on the worker thread in willDestroyWorkerContext.
   std::unique_ptr<WorkerContextData> context_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerContextClient);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CLIENT_H_