Chromium Code Reviews| Index: content/renderer/service_worker/service_worker_context_client.cc |
| diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc |
| index fb363187fd6025eb3ab42b8b37c010d254d11037..69c08be72d21ccee591759c6a8b3c06caddc2af5 100644 |
| --- a/content/renderer/service_worker/service_worker_context_client.cc |
| +++ b/content/renderer/service_worker/service_worker_context_client.cc |
| @@ -256,6 +256,8 @@ struct ServiceWorkerContextClient::WorkerContextData { |
| IDMap<std::unique_ptr<blink::WebServiceWorkerClientCallbacks>>; |
| using SkipWaitingCallbacksMap = |
| IDMap<std::unique_ptr<blink::WebServiceWorkerSkipWaitingCallbacks>>; |
| + using InstallEventCallbacksMap = |
| + IDMap<std::unique_ptr<const DispatchInstallEventCallback>>; |
| using ActivateEventCallbacksMap = |
| IDMap<std::unique_ptr<const DispatchActivateEventCallback>>; |
| using BackgroundFetchAbortEventCallbacksMap = |
| @@ -302,6 +304,9 @@ struct ServiceWorkerContextClient::WorkerContextData { |
| // Pending callbacks for ClaimClients(). |
| ClaimClientsCallbacksMap claim_clients_callbacks; |
| + // Pending callbacks for Install Events. |
| + InstallEventCallbacksMap install_event_callbacks; |
| + |
| // Pending callbacks for Activate Events. |
| ActivateEventCallbacksMap activate_event_callbacks; |
| @@ -500,7 +505,6 @@ void ServiceWorkerContextClient::OnMessageReceived( |
| CHECK_EQ(embedded_worker_id_, embedded_worker_id); |
| bool handled = true; |
| IPC_BEGIN_MESSAGE_MAP(ServiceWorkerContextClient, message) |
| - IPC_MESSAGE_HANDLER(ServiceWorkerMsg_InstallEvent, OnInstallEvent) |
| IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidGetClient, OnDidGetClient) |
| IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidGetClients, OnDidGetClients) |
| IPC_MESSAGE_HANDLER(ServiceWorkerMsg_OpenWindowResponse, |
| @@ -661,7 +665,14 @@ void ServiceWorkerContextClient::willDestroyWorkerContext( |
| // (while we're still on the worker thread). |
| proxy_ = NULL; |
| - // Aborts all the pending events callbacks. |
| + // Aborts the all pending install event callbacks. |
| + for (WorkerContextData::InstallEventCallbacksMap::iterator it( |
| + &context_->install_event_callbacks); |
| + !it.IsAtEnd(); it.Advance()) { |
| + it.GetCurrentValue()->Run(SERVICE_WORKER_ERROR_ABORT, false, |
|
shimazu
2017/04/05 05:01:27
I think you can use AbortPendingEventCallbacks for
|
| + base::Time::Now()); |
| + } |
| + // Aborts all other pending events callbacks. |
| AbortPendingEventCallbacks(context_->activate_event_callbacks); |
| AbortPendingEventCallbacks(context_->background_fetch_abort_event_callbacks); |
| AbortPendingEventCallbacks(context_->background_fetch_click_event_callbacks); |
| @@ -832,9 +843,12 @@ void ServiceWorkerContextClient::didHandleInstallEvent( |
| int request_id, |
| blink::WebServiceWorkerEventResult result, |
| double event_dispatch_time) { |
| - Send(new ServiceWorkerHostMsg_InstallEventFinished( |
| - GetRoutingID(), request_id, result, proxy_->hasFetchEventHandler(), |
| - base::Time::FromDoubleT(event_dispatch_time))); |
| + const DispatchInstallEventCallback* callback = |
| + context_->install_event_callbacks.Lookup(request_id); |
| + DCHECK(callback); |
| + callback->Run(EventResultToStatus(result), proxy_->hasFetchEventHandler(), |
| + base::Time::FromDoubleT(event_dispatch_time)); |
| + context_->install_event_callbacks.Remove(request_id); |
| } |
| void ServiceWorkerContextClient::respondToFetchEvent( |
| @@ -1021,9 +1035,15 @@ void ServiceWorkerContextClient::claim( |
| void ServiceWorkerContextClient::registerForeignFetchScopes( |
| const blink::WebVector<blink::WebURL>& sub_scopes, |
| const blink::WebVector<blink::WebSecurityOrigin>& origins) { |
| - Send(new ServiceWorkerHostMsg_RegisterForeignFetchScopes( |
| - GetRoutingID(), std::vector<GURL>(sub_scopes.begin(), sub_scopes.end()), |
| - std::vector<url::Origin>(origins.begin(), origins.end()))); |
| + std::vector<GURL> urls; |
| + for (const auto& url : sub_scopes) |
| + urls.push_back(url); |
| + |
| + std::vector<url::Origin> url_origins; |
| + for (const auto& origin : origins) |
| + url_origins.push_back(origin); |
| + |
| + install_method_client_->Register(urls, url_origins); |
| } |
| void ServiceWorkerContextClient::DispatchSyncEvent( |
| @@ -1171,6 +1191,19 @@ void ServiceWorkerContextClient::DispatchBackgroundFetchedEvent( |
| request_id, blink::WebString::fromUTF8(tag), web_fetches); |
| } |
| +void ServiceWorkerContextClient::DispatchInstallEvent( |
| + mojom::InstallEventMethodAssociatedPtrInfo client, |
| + const DispatchInstallEventCallback& callback) { |
| + TRACE_EVENT0("ServiceWorker", |
| + "ServiceWorkerContextClient::DispatchInstallEvent"); |
| + |
| + install_method_client_.Bind(std::move(client)); |
| + |
| + int request_id = context_->install_event_callbacks.Add( |
| + base::MakeUnique<DispatchInstallEventCallback>(callback)); |
| + proxy_->dispatchInstallEvent(request_id); |
| +} |
| + |
| void ServiceWorkerContextClient::DispatchExtendableMessageEvent( |
| mojom::ExtendableMessageEventPtr event, |
| const DispatchExtendableMessageEventCallback& callback) { |
| @@ -1206,12 +1239,6 @@ void ServiceWorkerContextClient::DispatchExtendableMessageEvent( |
| WebServiceWorkerImpl::CreateHandle(worker)); |
| } |
| -void ServiceWorkerContextClient::OnInstallEvent(int request_id) { |
| - TRACE_EVENT0("ServiceWorker", |
| - "ServiceWorkerContextClient::OnInstallEvent"); |
| - proxy_->dispatchInstallEvent(request_id); |
| -} |
| - |
| void ServiceWorkerContextClient::DispatchFetchEvent( |
| int fetch_event_id, |
| const ServiceWorkerFetchRequest& request, |