Fix shouldOverrideUrlLoading being called with the wrong is_redirect value with PlzNavigate.

Fix shouldOverrideUrlLoading being called with the wrong is_redirect value with PlzNavigate.

The problem was that with PlzNavigate, when the navigation in the renderer happens we already have the full list of redirects. So the logic to determine if the first url was a redirect was failing. Fix that, and also remove an assert that legitimately happens when the embedder cancels a redirect.

This fixes
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_
with PlzNavigate.

BUG=645983
Review-Url: https://codereview.chromium.org/2746733002
Cr-Commit-Position: refs/heads/master@{#456452}
Committed: https://chromium.googlesource.com/chromium/src/+/8a995f1eb09b00382fc071d347d59cc87c2544b2

[jam, 2017-03-12 08:20:34]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 08:20:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-12 08:21:21]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 08:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 09:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-12 09:15:13]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-13 14:35:45]

Description was changed from

==========
Fix

AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_

BUG=645983
==========

to

==========
Fix shouldOverrideUrlLoading being called with the wrong is_redirect value with
PlzNavigate.

The problem was that with PlzNavigate, when the navigation in the renderer
happens we already have the full list of redirects. So the logic to determine if
the first url was a redirect was failing. Fix that, and also remove an assert
that legitimately happens when the embedder cancels a redirect.

This fixes
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_
with PlzNavigate.

BUG=645983
==========

[jam, 2017-03-13 14:35:45]

jam@chromium.org changed reviewers:
+ sgurun@chromium.org

[sgurun-gerrit only, 2017-03-13 15:28:25]

On 2017/03/13 14:35:57, jam wrote:

lgtm,

I was hunting for the reason for these redirect tests failing. Thanks!!

[jam, 2017-03-13 16:01:01]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:01:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 17:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:20:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-03-13 17:50:27]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:50:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 20:10:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489427427294390,
"parent_rev": "3e8b266289d8dba16af796b0bcc491ac787eb326", "commit_rev":
"8a995f1eb09b00382fc071d347d59cc87c2544b2"}

[commit-bot: I haz the power, 2017-03-13 20:11:21]

Description was changed from

==========
Fix shouldOverrideUrlLoading being called with the wrong is_redirect value with
PlzNavigate.

The problem was that with PlzNavigate, when the navigation in the renderer
happens we already have the full list of redirects. So the logic to determine if
the first url was a redirect was failing. Fix that, and also remove an assert
that legitimately happens when the embedder cancels a redirect.

This fixes
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_
with PlzNavigate.

BUG=645983
==========

to

==========
Fix shouldOverrideUrlLoading being called with the wrong is_redirect value with
PlzNavigate.

The problem was that with PlzNavigate, when the navigation in the renderer
happens we already have the full list of redirects. So the logic to determine if
the first url was a redirect was failing. Fix that, and also remove an assert
that legitimately happens when the embedder cancels a redirect.

This fixes
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect
AwContentsClientShouldOverrideUrlLoadingTest_testCalledOn302Redirect_with__--webview-sandboxed-renderer_
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect
AwContentsClientShouldOverrideUrlLoadingTest_testNullContentsClientWithServerRedirect_with__--webview-sandboxed-renderer_
with PlzNavigate.

BUG=645983

Review-Url: https://codereview.chromium.org/2746733002
Cr-Commit-Position: refs/heads/master@{#456452}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a995f1eb09b00382fc071d347d5...
==========

[commit-bot: I haz the power, 2017-03-13 20:11:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8a995f1eb09b00382fc071d347d5...