Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: content/child/web_url_loader_impl.cc

Issue 2746733002: Fix shouldOverrideUrlLoading being called with the wrong is_redirect value with PlzNavigate. (Closed)
Patch Set: without PlzNavigate Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_loader_impl.h" 5 #include "content/child/web_url_loader_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <memory> 10 #include <memory>
(...skipping 699 matching lines...) Expand 10 before | Expand all | Expand 10 after
710 stream_override_->response.encoded_data_length - 710 stream_override_->response.encoded_data_length -
711 initial_info.encoded_data_length; 711 initial_info.encoded_data_length;
712 info = stream_override_->response; 712 info = stream_override_->response;
713 713
714 // Replay the redirects that happened during navigation. 714 // Replay the redirects that happened during navigation.
715 DCHECK_EQ(stream_override_->redirect_responses.size(), 715 DCHECK_EQ(stream_override_->redirect_responses.size(),
716 stream_override_->redirect_infos.size()); 716 stream_override_->redirect_infos.size());
717 for (size_t i = 0; i < stream_override_->redirect_responses.size(); ++i) { 717 for (size_t i = 0; i < stream_override_->redirect_responses.size(); ++i) {
718 bool result = OnReceivedRedirect(stream_override_->redirect_infos[i], 718 bool result = OnReceivedRedirect(stream_override_->redirect_infos[i],
719 stream_override_->redirect_responses[i]); 719 stream_override_->redirect_responses[i]);
720 if (!result) { 720 if (!result)
721 NOTREACHED();
722 return; 721 return;
723 }
724 } 722 }
725 } 723 }
726 724
727 WebURLResponse response; 725 WebURLResponse response;
728 GURL url(request_.url()); 726 GURL url(request_.url());
729 PopulateURLResponse(url, info, &response, request_.reportRawHeaders()); 727 PopulateURLResponse(url, info, &response, request_.reportRawHeaders());
730 728
731 bool show_raw_listing = false; 729 bool show_raw_listing = false;
732 if (info.mime_type == "text/vnd.chromium.ftp-dir") { 730 if (info.mime_type == "text/vnd.chromium.ftp-dir") {
733 if (url.query_piece() == "raw") { 731 if (url.query_piece() == "raw") {
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
1250 int intra_priority_value) { 1248 int intra_priority_value) {
1251 context_->DidChangePriority(new_priority, intra_priority_value); 1249 context_->DidChangePriority(new_priority, intra_priority_value);
1252 } 1250 }
1253 1251
1254 void WebURLLoaderImpl::setLoadingTaskRunner( 1252 void WebURLLoaderImpl::setLoadingTaskRunner(
1255 base::SingleThreadTaskRunner* loading_task_runner) { 1253 base::SingleThreadTaskRunner* loading_task_runner) {
1256 context_->SetTaskRunner(loading_task_runner); 1254 context_->SetTaskRunner(loading_task_runner);
1257 } 1255 }
1258 1256
1259 } // namespace content 1257 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698