Make lgarron@ an owner of (desktop) Page Info UI code and create a page_info watchlist.

Make lgarron@ an owner of (desktop) Page Info UI code and create a page_info watchlist.

BUG=661797, 661796, 661799
Review-Url: https://codereview.chromium.org/2746663002
Cr-Commit-Position: refs/heads/master@{#456986}
Committed: https://chromium.googlesource.com/chromium/src/+/9e25c740eaab6422e20ff84f4dc9990c6405a866

[lgarron, 2017-03-11 00:52:12]

lgarron@chromium.org changed reviewers:
+ felt@chromium.org, rsesek@chromium.org

[lgarron, 2017-03-11 00:52:12]

felt@, rsesek@, could you review?

[felt, 2017-03-11 00:54:15]

lgtm

[lgarron, 2017-03-11 02:16:45]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 02:17:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 02:20:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:20:33]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[raymes, 2017-03-13 02:26:48]

raymes@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2017-03-13 02:26:48]

https://codereview.chromium.org/2746663002/diff/1/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/2746663002/diff/1/WATCHLISTS#newcode2051
WATCHLISTS:2051: 'page_info' : ['lgarron+watch@chromium.org'],
Could you please add me? :)

[Robert Sesek, 2017-03-13 16:30:00]

Are the current set of cocoa/ OWNERS currently an issue? Because Cocoa differs
so much from the other platforms' code, we like to have a Mac person approving
.mm CLs.

[palmer, 2017-03-13 19:36:44]

palmer@chromium.org changed reviewers:
+ palmer@chromium.org

[palmer, 2017-03-13 19:36:45]

lgtm

[lgarron, 2017-03-13 19:46:45]

On 2017/03/13 at 16:30:00, rsesek wrote:
> Are the current set of cocoa/ OWNERS currently an issue? Because Cocoa differs
so much from the other platforms' code, we like to have a Mac person approving
.mm CLs.

I don't intend to LGTM non-trivial Mac code. How would you feel about taking a
page from one of the old website_settings OWNERS files and having a section "#
Please use the following reviewers for LGTM" at the top of the file?

[lgarron, 2017-03-13 19:47:21]

On 2017/03/13 at 19:46:45, lgarron wrote:
> On 2017/03/13 at 16:30:00, rsesek wrote:
> > Are the current set of cocoa/ OWNERS currently an issue? Because Cocoa
differs so much from the other platforms' code, we like to have a Mac person
approving .mm CLs.
> 
> I don't intend to LGTM non-trivial Mac code. How would you feel about taking a
page from one of the old website_settings OWNERS files and having a section "#
Please use the following reviewers for LGTM" at the top of the file?

(I really wish we distinguished between "approvers" and "maintainers" instead of
lumping them in OWNERS. :-/ )

[Robert Sesek, 2017-03-13 19:47:38]

On 2017/03/13 19:47:21, lgarron wrote:
> On 2017/03/13 at 19:46:45, lgarron wrote:
> > On 2017/03/13 at 16:30:00, rsesek wrote:
> > > Are the current set of cocoa/ OWNERS currently an issue? Because Cocoa
> differs so much from the other platforms' code, we like to have a Mac person
> approving .mm CLs.
> > 
> > I don't intend to LGTM non-trivial Mac code. How would you feel about taking
a
> page from one of the old website_settings OWNERS files and having a section "#
> Please use the following reviewers for LGTM" at the top of the file?

SG

> (I really wish we distinguished between "approvers" and "maintainers" instead
of
> lumping them in OWNERS. :-/ )

Yeah, me too.

[lgarron, 2017-03-14 21:31:37]

rsesek@: Cocoa OWNERS updated; could you review again?

https://codereview.chromium.org/2746663002/diff/1/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/2746663002/diff/1/WATCHLISTS#newcode2051
WATCHLISTS:2051: 'page_info' : ['lgarron+watch@chromium.org'],
On 2017/03/13 at 02:26:48, raymes wrote:
> Could you please add me? :)

Done.

(That will also sign you up for iOS and Android updates. Those are low-volume,
but if you find you don't want those we can refactor into page_info_desktop and
page_info_mobile.)

[Robert Sesek, 2017-03-14 21:32:27]

lgtm

[raymes, 2017-03-14 23:13:16]

On 2017/03/14 21:31:37, lgarron wrote:
> rsesek@: Cocoa OWNERS updated; could you review again?
> 
> https://codereview.chromium.org/2746663002/diff/1/WATCHLISTS
> File WATCHLISTS (right):
> 
> https://codereview.chromium.org/2746663002/diff/1/WATCHLISTS#newcode2051
> WATCHLISTS:2051: 'page_info' : mailto:[,
> On 2017/03/13 at 02:26:48, raymes wrote:
> > Could you please add me? :)
> 
> Done.
> 
> (That will also sign you up for iOS and Android updates. Those are low-volume,
> but if you find you don't want those we can refactor into page_info_desktop
and
> page_info_mobile.)

That sounds ok for now :)

[lgarron, 2017-03-15 00:19:15]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 00:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:30:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:30:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lgarron, 2017-03-15 03:16:47]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-03-15 03:16:48]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
felt@chromium.org, rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2746663002/#ps40001
(title: "Rebase to update patch dependency.")

[commit-bot: I haz the power, 2017-03-15 03:17:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 04:03:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489547807684720,
"parent_rev": "0b110db84a13d9087ddf55b5e99d961e54f55e16", "commit_rev":
"9e25c740eaab6422e20ff84f4dc9990c6405a866"}

[commit-bot: I haz the power, 2017-03-15 04:04:01]

Description was changed from

==========
Make lgarron@ an owner of (desktop) Page Info UI code and create a page_info
watchlist.

BUG=661797, 661796, 661799
==========

to

==========
Make lgarron@ an owner of (desktop) Page Info UI code and create a page_info
watchlist.

BUG=661797, 661796, 661799

Review-Url: https://codereview.chromium.org/2746663002
Cr-Commit-Position: refs/heads/master@{#456986}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e25c740eaab6422e20ff84f4dc9...
==========

[commit-bot: I haz the power, 2017-03-15 04:04:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e25c740eaab6422e20ff84f4dc9...