Send deprecation messages for prefixed gradients now that it's possible.

Send deprecation messages for prefixed gradients now that it's possible.

R=japhet@chromium.org, schenney@chromium.org, suzyh@chromium.org
BUG=668251
Review-Url: https://codereview.chromium.org/2746583003 .
Cr-Commit-Position: refs/heads/master@{#469084}
Committed: https://chromium.googlesource.com/chromium/src/+/840c7ecc54c9c9e4b2e6be21065041ec7ba71623

[Bret, 2017-03-10 22:18:21]

Description was changed from

==========
Send deprecation messages for prefixed gradients now that it's possible.

BUG=668251
==========

to

==========
Send deprecation messages for prefixed gradients now that it's possible.

BUG=668251
==========

[Bret, 2017-03-10 22:18:21]

bsep@chromium.org changed reviewers:
+ japhet@chromium.org

[Nate Chapin, 2017-03-11 00:47:40]

lgtm

[Bret, 2017-03-11 00:48:31]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-03-11 00:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 02:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:18:50]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bret, 2017-03-14 22:15:09]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 22:16:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:20:57]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bret, 2017-03-15 00:38:14]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 00:39:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 02:18:27]

Dry run: This issue passed the CQ dry run.

[Bret, 2017-03-15 21:23:07]

> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,

A bunch of tests failed because of the new deprecation messages. I erred on the
side of changing them to use the newer syntax unless they were a crash test,
PTAL.

[Bret, 2017-03-22 00:13:05]

Friendly ping.

[Bret, 2017-03-29 21:58:25]

bsep@chromium.org changed reviewers:
+ suzyh@chromium.org

[Bret, 2017-03-29 22:01:05]

Adding suzyh@ for someone who's more familiar with CSS to review the test
changes, PTAL. In some cases I didn't see how it was possible to recreate the
prefixed behavior with the non-prefixed version of gradients so I left them
alone. I also left crash tests alone.

[suzyh_UTC10 (ex-contributor), 2017-03-30 00:00:24]

I don't have much experience actually using gradients so just from eyeballing
this change I can't tell you whether the changes made are sane. If the test
changes don't cause any test failures, then I would guess they're probably OK,
but you have added a lot of NeedsRebaseline lines, and I haven't verified
whether those NeedsRebaseline lines are for the tests you've modified or for the
ones you say you're not touching. I'd prefer to see a manual rebaseline in the
patch so I can see what the effect of the change is.

https://codereview.chromium.org/2746583003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html
(right):

https://codereview.chromium.org/2746583003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html:29:
background-image: linear-gradient(-225deg, white, black);
Why do some of these angles change?

[Bret, 2017-03-30 00:31:54]

On 2017/03/30 00:00:24, suzyh wrote:
> I don't have much experience actually using gradients so just from eyeballing
> this change I can't tell you whether the changes made are sane. If the test
> changes don't cause any test failures, then I would guess they're probably OK,
> but you have added a lot of NeedsRebaseline lines, and I haven't verified
> whether those NeedsRebaseline lines are for the tests you've modified or for
the
> ones you say you're not touching. I'd prefer to see a manual rebaseline in the
> patch so I can see what the effect of the change is.

I'll separate the changes into manual rebaselines for tests I changed and
NeedsRebaseline for tests that I didn't touch and are just failing because
they're now emitting a deprecation message.

>
https://codereview.chromium.org/2746583003/diff/40001/third_party/WebKit/Layo...
> File
> third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html
> (right):
> 
>
https://codereview.chromium.org/2746583003/diff/40001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html:29:
> background-image: linear-gradient(-225deg, white, black);
> Why do some of these angles change?

The general answer is that prefixed gradients default to horizontal and
non-prefixed default to vertical. I need to re-review this if you have questions
about a specific change though; feel free to leave them as comments and I'll
answer them as I make the manual rebaselines.

[Bret, 2017-03-31 01:23:30]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 01:24:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 02:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 02:43:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2017-03-31 21:36:12]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 21:36:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 23:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 23:10:17]

Dry run: This issue passed the CQ dry run.

[Bret, 2017-04-01 21:20:58]

On 2017/03/30 00:31:54, Bret Sepulveda wrote:
> I'll separate the changes into manual rebaselines for tests I changed and
> NeedsRebaseline for tests that I didn't touch and are just failing because
> they're now emitting a deprecation message.

This is done. The tests I changed that still needed a rebaseline are now all
manual.

[suzyh_UTC10 (ex-contributor), 2017-04-03 01:00:04]

suzyh@chromium.org changed reviewers:
+ schenney@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-04-03 01:00:05]

lgtm but I'd prefer a review from someone more familiar with gradients.
+schenney Could you recommend someone from Paint to sanity-check this patch?

BTW are you aware of crbug.com/505349?

https://codereview.chromium.org/2746583003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html
(right):

https://codereview.chromium.org/2746583003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html:29:
background-image: linear-gradient(-225deg, white, black);
Since this test (and some others) now has a mix of prefixed and unprefixed
cases, and some of the unprefixed cases have involved changes to these angle
arguments, I'd feel better if someone familiar with gradients gave their OK as
well.

[Stephen Chennney, 2017-04-04 18:01:24]

I'm also not very familiar with the syntax, so I have some follow up questions.

In general, I would like to avoid deprecation messages wherever possible, and
have specific tests for the deprecation message appearing.

I would also be more comfortable seeing all the rebaselines. Are you familiar
with the process for getting new baselines to include in the patch? That is, the
webkit-patch rebaseline-cl method?

https://codereview.chromium.org/2746583003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html
(right):

https://codereview.chromium.org/2746583003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html:37:
background-image: -webkit-linear-gradient(top left, white -20%, black 120%);
Why did you skip these 3? If we no longer support them due to syntax changes, I
would argue for removing the test case.

https://codereview.chromium.org/2746583003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/gradients/css3-repeating-linear-gradients.html
(right):

https://codereview.chromium.org/2746583003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/css3-repeating-linear-gradients.html:24:
background-image: -webkit-repeating-linear-gradient(top left, red, blue 20px,
red 40px);
And this one too.

[Bret, 2017-04-05 01:23:09]

> I would also be more comfortable seeing all the rebaselines. Are you familiar
> with the process for getting new baselines to include in the patch? That is,
the
> webkit-patch rebaseline-cl method?

Ah, that seems useful! I haven't written a patch for Blink that needed
rebaselines in a while. I'll take care of that after I go through and change the
tests again.

https://codereview.chromium.org/2746583003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html
(right):

https://codereview.chromium.org/2746583003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/css3-linear-angle-gradients.html:37:
background-image: -webkit-linear-gradient(top left, white -20%, black 120%);
On 2017/04/04 18:01:24, Stephen Chennney wrote:
> Why did you skip these 3? If we no longer support them due to syntax changes,
I
> would argue for removing the test case.

I expected to be able to change these to "linear-gradient(to bottom right,
[etc])" but that results in a slightly different image. It looks reasonable to
me both ways so I'm not sure which one is "correct," though I suppose it'd be
the un-prefixed one because it's newer.

I erred on the side of not updating the images, but if you'd rather I can err on
the side of removing prefixed calls instead. If that's the case, do you also
prefer I change crash tests? I will make an explicit "prefixed calls send a
deprecation message" test if so.

[Bret, 2017-04-12 21:27:06]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 21:27:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:34:51]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bret, 2017-04-13 02:03:26]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 02:05:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:58:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2017-04-14 00:34:54]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 00:35:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 02:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 02:25:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2017-04-16 01:46:51]

This is ready for re-review. I changed prefixed gradients more aggressively, and
then manually rebaselined everything. I still left the crash tests alone. These
tests I have no clue how to recreate using non-prefixed gradients so I left them
alone, but I can delete them instead if you would like:
* border-image-gradient.html
* border-image-gradient-sides-and-corners.html
* generated-gradients.html
* radial-centered.html
* simple-gradients.html

[Stephen Chennney, 2017-04-17 13:21:42]

On 2017/04/16 01:46:51, Bret Sepulveda wrote:
> This is ready for re-review. I changed prefixed gradients more aggressively,
and
> then manually rebaselined everything. I still left the crash tests alone.
These
> tests I have no clue how to recreate using non-prefixed gradients so I left
them
> alone, but I can delete them instead if you would like:
> * border-image-gradient.html
> * border-image-gradient-sides-and-corners.html
> * generated-gradients.html
> * radial-centered.html
> * simple-gradients.html

lgtm, with a request to file a bug on updating the remaining tests. Then we can
discuss
what to do without the complication of all the other tests changing.

[Bret, 2017-04-25 20:05:05]

The CQ bit was checked by bsep@chromium.org

[Bret, 2017-04-25 20:05:06]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2746583003/#ps200001
(title: "add expectations for linux")

[commit-bot: I haz the power, 2017-04-25 20:06:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 20:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:11:35]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Bret, 2017-04-25 22:13:45]

The CQ bit was checked by bsep@chromium.org

[Bret, 2017-04-25 22:13:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
schenney@chromium.org, japhet@chromium.org, suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2746583003/#ps220001
(title: "merge")

[commit-bot: I haz the power, 2017-04-25 22:14:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bret, 2017-04-25 22:14:51]

On 2017/04/17 13:21:42, Stephen Chennney wrote:
> On 2017/04/16 01:46:51, Bret Sepulveda wrote:
> > This is ready for re-review. I changed prefixed gradients more aggressively,
> and
> > then manually rebaselined everything. I still left the crash tests alone.
> These
> > tests I have no clue how to recreate using non-prefixed gradients so I left
> them
> > alone, but I can delete them instead if you would like:
> > * border-image-gradient.html
> > * border-image-gradient-sides-and-corners.html
> > * generated-gradients.html
> > * radial-centered.html
> > * simple-gradients.html
> 
> lgtm, with a request to file a bug on updating the remaining tests. Then we
can
> discuss
> what to do without the complication of all the other tests changing.

Filed as crbug.com/715281. Thanks for reviewing, everyone!

[commit-bot: I haz the power, 2017-04-25 22:33:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:33:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bret, 2017-04-26 00:44:38]

Description was changed from

==========
Send deprecation messages for prefixed gradients now that it's possible.

BUG=668251
==========

to

==========
Send deprecation messages for prefixed gradients now that it's possible.

TBR=schenney@chromium.org
BUG=668251
==========

[Bret, 2017-04-26 00:46:09]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:46:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 02:59:32]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1493167569535550,
"parent_rev": "672c108a285f4e8a3e9f4705af5b488cac4d8010", "commit_rev":
"f8fafa5c816e39a2f4700d2be495618da9ea73c2"}

[commit-bot: I haz the power, 2017-04-26 02:59:42]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1493167569535550,
"parent_rev": "672c108a285f4e8a3e9f4705af5b488cac4d8010", "commit_rev":
"f8fafa5c816e39a2f4700d2be495618da9ea73c2"}

[commit-bot: I haz the power, 2017-04-26 02:59:53]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1493167569535550,
"parent_rev": "672c108a285f4e8a3e9f4705af5b488cac4d8010", "commit_rev":
"f8fafa5c816e39a2f4700d2be495618da9ea73c2"}

[commit-bot: I haz the power, 2017-04-26 03:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 03:00:05]

Failed to commit the patch.

[Stephen Chennney, 2017-04-26 13:11:23]

On 2017/04/26 03:00:05, commit-bot: I haz the power wrote:
> Failed to commit the patch.

lgtm, again, to see if that fixes presubmit.

[Stephen Chennney, 2017-04-26 13:11:36]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2017-04-26 13:11:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 13:19:58]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1493212296313450,
"parent_rev": "79a8c1f3a373b60846fd2a163966b7f8e30991a6", "commit_rev":
"d3529eee92611f2a0267ff1100cb2f93259e852e"}

[commit-bot: I haz the power, 2017-04-26 13:20:15]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1493212296313450,
"parent_rev": "79a8c1f3a373b60846fd2a163966b7f8e30991a6", "commit_rev":
"d3529eee92611f2a0267ff1100cb2f93259e852e"}

[commit-bot: I haz the power, 2017-04-26 13:20:29]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1493212296313450,
"parent_rev": "79a8c1f3a373b60846fd2a163966b7f8e30991a6", "commit_rev":
"d3529eee92611f2a0267ff1100cb2f93259e852e"}

[commit-bot: I haz the power, 2017-04-26 13:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 13:20:39]

Failed to commit the patch.

[Stephen Chennney, 2017-04-26 13:26:21]

On 2017/04/26 13:20:39, commit-bot: I haz the power wrote:
> Failed to commit the patch.

Looks like another rebase is needed. I apologise on behalf of the organization
for all the annoyance this patch has caused you.

[Bret, 2017-04-26 22:04:47]

The CQ bit was checked by bsep@chromium.org

[Bret, 2017-04-26 22:04:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
schenney@chromium.org, japhet@chromium.org, suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2746583003/#ps240001
(title: "rebased again")

[commit-bot: I haz the power, 2017-04-26 22:05:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:04:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:04:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bret, 2017-04-27 01:07:26]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-04-27 01:08:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 03:04:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 03:04:16]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Stephen Chennney, 2017-04-27 13:12:11]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2017-04-27 13:12:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 13:57:05]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1493298731748020,
"parent_rev": "95bfc8dbca7ee83b4d8f3f352f7b6862ca31c559", "commit_rev":
"58d9a716dafc2fd733882ea82ab92be185fa038b"}

[commit-bot: I haz the power, 2017-04-27 13:57:18]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1493298731748020,
"parent_rev": "95bfc8dbca7ee83b4d8f3f352f7b6862ca31c559", "commit_rev":
"58d9a716dafc2fd733882ea82ab92be185fa038b"}

[commit-bot: I haz the power, 2017-04-27 13:57:30]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1493298731748020,
"parent_rev": "95bfc8dbca7ee83b4d8f3f352f7b6862ca31c559", "commit_rev":
"58d9a716dafc2fd733882ea82ab92be185fa038b"}

[commit-bot: I haz the power, 2017-04-27 13:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 13:57:43]

Failed to commit the patch.

[Bret, 2017-05-03 19:50:52]

Description was changed from

==========
Send deprecation messages for prefixed gradients now that it's possible.

TBR=schenney@chromium.org
BUG=668251
==========

to

==========
Send deprecation messages for prefixed gradients now that it's possible.

R=japhet@chromium.org, schenney@chromium.org, suzyh@chromium.org
BUG=668251

Review-Url: https://codereview.chromium.org/2746583003 .
Cr-Commit-Position: refs/heads/master@{#469084}
Committed:
https://chromium.googlesource.com/chromium/src/+/840c7ecc54c9c9e4b2e6be210650...
==========

[Bret, 2017-05-03 19:50:55]

Committed patchset #14 (id:260001) manually as
840c7ecc54c9c9e4b2e6be21065041ec7ba71623 (presubmit successful).

[Timothy Loh, 2017-05-04 03:13:18]

timloh@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2017-05-04 03:13:20]

This needs an intent thread on blink-dev. Most of these have entries in the
compat spec so we probably don't even want to warn on those.

https://www.chromium.org/blink/removing-features
https://compat.spec.whatwg.org/#css-%3Cimage%3E-type

[Bret, 2017-05-04 19:34:58]

On 2017/05/04 03:13:20, Timothy Loh wrote:
> This needs an intent thread on blink-dev. Most of these have entries in the
> compat spec so we probably don't even want to warn on those.
> 
> https://www.chromium.org/blink/removing-features
> https://compat.spec.whatwg.org/#css-%3Cimage%3E-type

Oh, I wasn't going to delete them. I just thought they were already deprecated
due to the TODOs. I can revert sending deprecation messages if you think we
shouldn't do that. The test changes are still relevant, I think.

[Timothy Loh, 2017-05-05 01:21:22]

On 2017/05/04 19:34:58, Bret Sepulveda wrote:
> On 2017/05/04 03:13:20, Timothy Loh wrote:
> > This needs an intent thread on blink-dev. Most of these have entries in the
> > compat spec so we probably don't even want to warn on those.
> > 
> > https://www.chromium.org/blink/removing-features
> > https://compat.spec.whatwg.org/#css-%3Cimage%3E-type
> 
> Oh, I wasn't going to delete them. I just thought they were already deprecated
> due to the TODOs. I can revert sending deprecation messages if you think we
> shouldn't do that. The test changes are still relevant, I think.

Let's revert sending warnings, this would come under deprecating without a
removal deadline, which "is strongly discouraged and will require significant
justification".