Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2746583003: Send deprecation messages for prefixed gradients now that it's possible. (Closed)
Patch Set: recommit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
index f44719cb8bda5a2f0497bea00e3a5e30fed99ec5..203b4dc6c1cfb8eca151fad2f04fb42f6fd50f5c 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
@@ -1295,13 +1295,12 @@ static CSSValue* ConsumeGeneratedImage(CSSParserTokenRange& range,
} else if (id == CSSValueRepeatingRadialGradient) {
result = ConsumeRadialGradient(args, context->Mode(), kRepeating);
} else if (id == CSSValueWebkitLinearGradient) {
- // FIXME: This should send a deprecation message.
- context->Count(UseCounter::kDeprecatedWebKitLinearGradient);
+ context->CountDeprecation(UseCounter::kDeprecatedWebKitLinearGradient);
result = ConsumeLinearGradient(args, context->Mode(), kNonRepeating,
kCSSPrefixedLinearGradient);
} else if (id == CSSValueWebkitRepeatingLinearGradient) {
- // FIXME: This should send a deprecation message.
- context->Count(UseCounter::kDeprecatedWebKitRepeatingLinearGradient);
+ context->CountDeprecation(
+ UseCounter::kDeprecatedWebKitRepeatingLinearGradient);
result = ConsumeLinearGradient(args, context->Mode(), kRepeating,
kCSSPrefixedLinearGradient);
} else if (id == CSSValueRepeatingLinearGradient) {
@@ -1311,16 +1310,15 @@ static CSSValue* ConsumeGeneratedImage(CSSParserTokenRange& range,
result = ConsumeLinearGradient(args, context->Mode(), kNonRepeating,
kCSSLinearGradient);
} else if (id == CSSValueWebkitGradient) {
- // FIXME: This should send a deprecation message.
- context->Count(UseCounter::kDeprecatedWebKitGradient);
+ context->CountDeprecation(UseCounter::kDeprecatedWebKitGradient);
result = ConsumeDeprecatedGradient(args, context->Mode());
} else if (id == CSSValueWebkitRadialGradient) {
- // FIXME: This should send a deprecation message.
- context->Count(UseCounter::kDeprecatedWebKitRadialGradient);
+ context->CountDeprecation(UseCounter::kDeprecatedWebKitRadialGradient);
result =
ConsumeDeprecatedRadialGradient(args, context->Mode(), kNonRepeating);
} else if (id == CSSValueWebkitRepeatingRadialGradient) {
- context->Count(UseCounter::kDeprecatedWebKitRepeatingRadialGradient);
+ context->CountDeprecation(
+ UseCounter::kDeprecatedWebKitRepeatingRadialGradient);
result = ConsumeDeprecatedRadialGradient(args, context->Mode(), kRepeating);
} else if (id == CSSValueConicGradient) {
result = ConsumeConicGradient(args, context->Mode(), kNonRepeating);

Powered by Google App Engine
This is Rietveld 408576698