Fix several issues with VR instrumentation tests

Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      crbug.com/b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

TBR=dtrainor@chromium.org

BUG=671373
Review-Url: https://codereview.chromium.org/2746453003
Cr-Commit-Position: refs/heads/master@{#456752}
Committed: https://chromium.googlesource.com/chromium/src/+/70e3edf37a04a60bc3398c65d317de3e51353875

[bsheedy, 2017-03-09 23:44:23]

Description was changed from

==========
Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - VR Services setup did not work if VR Services had never been started before
      modifying the shared preferences file
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

BUG=671373
==========

to

==========
Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - VR Services setup did not work if VR Services had never been started before
      modifying the shared preferences file
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      crbug.com/b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

BUG=671373
==========

[bsheedy, 2017-03-10 00:01:45]

bsheedy@chromium.org changed reviewers:
+ dpranke@chromium.org, dtrainor@chromium.org, mthiesse@chromium.org

[bsheedy, 2017-03-10 00:01:46]

+dpranke for build/ and testing/buildbot changes
+mthiesse for VRShellDelegate change
+dtrainor for other chrome/android changes

https://codereview.chromium.org/2746453003/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2746453003/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:136: #
Workaround for Android's SharedPreferencesImpl failing to open
This is a very hacky workaround, but I've been unable to find another solution -
any better ideas would be greatly appreciated.

[Dirk Pranke, 2017-03-10 02:10:57]

dpranke@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Dirk Pranke, 2017-03-10 02:10:57]

//testing lgtm, but I'm not really qualified to review the //build change;
someone more knowledgeable about Android like jbudorick@ should review.

[jbudorick, 2017-03-10 02:19:22]

https://codereview.chromium.org/2746453003/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2746453003/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:136: #
Workaround for Android's SharedPreferencesImpl failing to open
On 2017/03/10 00:01:45, bsheedy wrote:
> This is a very hacky workaround, but I've been unable to find another solution
-
> any better ideas would be greatly appreciated.

Dollars to donuts that this is an SELinux issue. Can you write the shared prefs
normally if you disable it?

If it does, then a better solution would be to revise SharedPrefs to write the
preference file as the app, likely by writing to a temporary file on the device
and then copying it to its final location w/ run-as via RunShellCommand(...,
run_as=pref['package'])

[mthiesse, 2017-03-10 15:42:34]

vr_shell/ lgtm

SELinux is one of the most painful things I've ever had to deal with, good luck
Brian :P

[bsheedy, 2017-03-10 17:57:37]

On 2017/03/10 02:19:22, jbudorick wrote:
>
https://codereview.chromium.org/2746453003/diff/20001/build/android/pylib/loc...
> File build/android/pylib/local/device/local_device_instrumentation_test_run.py
> (right):
> 
>
https://codereview.chromium.org/2746453003/diff/20001/build/android/pylib/loc...
> build/android/pylib/local/device/local_device_instrumentation_test_run.py:136:
#
> Workaround for Android's SharedPreferencesImpl failing to open
> On 2017/03/10 00:01:45, bsheedy wrote:
> > This is a very hacky workaround, but I've been unable to find another
solution
> -
> > any better ideas would be greatly appreciated.
> 
> Dollars to donuts that this is an SELinux issue. Can you write the shared
prefs
> normally if you disable it?
> 
> If it does, then a better solution would be to revise SharedPrefs to write the
> preference file as the app, likely by writing to a temporary file on the
device
> and then copying it to its final location w/ run-as via RunShellCommand(...,
> run_as=pref['package'])

Yep, it's SELinux. The file reading works fine without the workaround if SELinux
is disabled. I'll update SharedPrefs with the change then ping on this issue
once the change is rolled.

[bsheedy, 2017-03-11 01:43:49]

Description was changed from

==========
Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - VR Services setup did not work if VR Services had never been started before
      modifying the shared preferences file
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      crbug.com/b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

BUG=671373
==========

to

==========
Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      crbug.com/b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

BUG=671373
==========

[bsheedy, 2017-03-11 01:46:07]

The SELinux issue was fixed in https://codereview.chromium.org/2743003003/.

[bsheedy, 2017-03-13 17:05:46]

Description was changed from

==========
Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      crbug.com/b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

BUG=671373
==========

to

==========
Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      crbug.com/b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

TBR=dtrainor@chromium.org

BUG=671373
==========

[bsheedy, 2017-03-13 17:07:15]

dtrainor@ is OOO, but said that it looks good and to TBR him, so I'll go ahead
and submit this.

[bsheedy, 2017-03-13 17:07:19]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2017-03-13 17:07:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2746453003/#ps40001
(title: "Remove preference file workaround")

[commit-bot: I haz the power, 2017-03-13 17:07:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 18:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 18:31:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bsheedy, 2017-03-13 18:36:23]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2017-03-13 18:36:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2746453003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-13 18:37:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 19:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 19:56:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bsheedy, 2017-03-13 20:25:29]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2017-03-13 20:25:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2746453003/#ps80001
(title: "Rebase again?")

[commit-bot: I haz the power, 2017-03-13 20:26:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 21:45:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 21:46:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Trainor- moved to gerrit, 2017-03-14 15:18:09]

I gave the tbr earlier, but to help out bots if necessary, lgtm.

[bsheedy, 2017-03-14 16:22:03]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2017-03-14 16:22:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, dtrainor@chromium.org, mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2746453003/#ps100001
(title: "Please work this time")

[commit-bot: I haz the power, 2017-03-14 16:23:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 17:31:24]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489508523703760,
"parent_rev": "b989a0bdb0d3c41f023aa5d249477a596cd5451f", "commit_rev":
"70e3edf37a04a60bc3398c65d317de3e51353875"}

[commit-bot: I haz the power, 2017-03-14 17:33:23]

Description was changed from

==========
Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      crbug.com/b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

TBR=dtrainor@chromium.org

BUG=671373
==========

to

==========
Fix several issues with VR instrumentation tests

Fixes the following issues that were occuring with VR instrumentation tests:
  - Daydream-readiness checking failing during restriction checks
  - Strict mode policy failure from VR Shell creation

There are still a number of issues preventing the tests from passing
consistently that will be addressed in separate CLs:
  - Strict mode violations from VR Services that are not fixable from Chrome
      ("--strict-mode off" added for time being to prevent failures)
      crbug.com/b/35628570
  - Null pointer exceptions crbug.com/699220
  - General test flakiness (looks like caused by VR Services, but not sure yet)

TBR=dtrainor@chromium.org

BUG=671373

Review-Url: https://codereview.chromium.org/2746453003
Cr-Commit-Position: refs/heads/master@{#456752}
Committed:
https://chromium.googlesource.com/chromium/src/+/70e3edf37a04a60bc3398c65d317...
==========

[commit-bot: I haz the power, 2017-03-14 17:33:26]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/70e3edf37a04a60bc3398c65d317...