Fix several issues with VR instrumentation tests

build/android/pylib/local/device/local_device_instrumentation_test_run.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import posixpath
 import re
 import tempfile
 import time
 
 from devil.android import device_errors
 from devil.android import flag_changer
+from devil.android.sdk import intent
 from devil.android.sdk import shared_prefs
 from devil.utils import reraiser_thread
 from pylib import valgrind_tools
 from pylib.android import logdog_logcat_monitor
 from pylib.constants import host_paths
 from pylib.base import base_test_result
 from pylib.instrumentation import instrumentation_test_instance
 from pylib.local.device import local_device_environment
 from pylib.local.device import local_device_test_run
 from pylib.utils import google_storage_helper
@@ skipping 101 matching lines @@
             logging.error("Couldn't set debug app: no package info")
           elif not self._test_instance.package_info.package:
             logging.error("Couldn't set debug app: no package defined")
           else:
             dev.RunShellCommand(['am', 'set-debug-app', '--persistent',
                                   self._test_instance.package_info.package],
                                 check_return=True)
 
       def edit_shared_prefs():
         for pref in self._test_instance.edit_shared_prefs:
+          # Workaround for Android's SharedPreferencesImpl failing to open

[bsheedy, 2017/03/10 00:01:45]

This is a very hacky workaround, but I've been unable to find another solution -
any better ideas would be greatly appreciated.

[jbudorick, 2017/03/10 02:19:21]

Dollars to donuts that this is an SELinux issue. Can you write the shared prefs
normally if you disable it?

If it does, then a better solution would be to revise SharedPrefs to write the
preference file as the app, likely by writing to a temporary file on the device
and then copying it to its final location w/ run-as via RunShellCommand(...,
run_as=pref['package'])

+          # shared preference files if they are created by something other
+          # than the process that uses them (see b/36093591), even with proper
+          # permissions, owner, and group.
+          # This gets around that by adding the option to start and kill
+          # an activity before modifying the preferences file, thus allowing
+          # the app to create a default file that can then be edited.
+          if 'start_and_kill_activity' in pref:
+            act_options = pref['start_and_kill_activity']
+            dev.StartActivity(intent.Intent(
+                action=act_options.get('action', None),
+                activity=act_options.get('activity', None),
+                category=act_options.get('category', None),
+                component=act_options.get('component', None),
+                data=act_options.get('data', None),
+                extras=act_options.get('extras', None),
+                flags=act_options.get('flags', None),
+                package=pref['package']))
+            dev.ForceStop(pref['package'])
+
           prefs = shared_prefs.SharedPrefs(dev, pref['package'],
                                            pref['filename'])
           prefs.Load()
           for key in pref.get('remove', []):
             try:
               prefs.Remove(key)
             except KeyError:
               logging.warning("Attempted to remove non-existent key %s", key)
           for key, value in pref.get('set', {}).iteritems():
             if isinstance(value, bool):
@@ skipping 398 matching lines @@
         timeout = v
         break
     else:
       logging.warning('Using default 1 minute timeout for %s', test_name)
       timeout = 60
 
     timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)
 
     return timeout