Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2746453002: [NTP::SectionOrder] Add fieldtrial_testing_config for the experiment. (Closed)

Created:
3 years, 9 months ago by vitaliii
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::SectionOrder] Add fieldtrial_testing_config for the experiment. The feature has been disabled in M57 (https://codereview.chromium.org/2719473002). Therefore, now we add fieldtrial_testing_config for the experiment. BUG=646841 Review-Url: https://codereview.chromium.org/2746453002 Cr-Commit-Position: refs/heads/master@{#456014} Committed: https://chromium.googlesource.com/chromium/src/+/fb8fb40d02986e2f2cf2233d8dbe3b8cd0b74920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
vitaliii
Hi treib@, Could you have a look please?
3 years, 9 months ago (2017-03-09 17:02:33 UTC) #3
Marc Treib
non-OWNERS lgtm
3 years, 9 months ago (2017-03-09 17:12:08 UTC) #5
vitaliii
Hi asvitkine@, Could you have a look as an OWNER?
3 years, 9 months ago (2017-03-09 17:13:42 UTC) #7
Alexei Svitkine (slow)
lgtm
3 years, 9 months ago (2017-03-09 17:27:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746453002/1
3 years, 9 months ago (2017-03-10 07:12:54 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 07:18:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb8fb40d02986e2f2cf2233d8dbe...

Powered by Google App Engine
This is Rietveld 408576698