Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2719473002: [NTP::PhysicalWeb] Disable feature by default. (Closed)

Created:
3 years, 10 months ago by vitaliii
Modified:
3 years, 10 months ago
Reviewers:
jkrcal
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::PhysicalWeb] Disable feature by default. BUG=666647 Review-Url: https://codereview.chromium.org/2719473002 Cr-Commit-Position: refs/heads/master@{#452802} Committed: https://chromium.googlesource.com/chromium/src/+/8ea3b8e1f7c6738a53e11c4dc58ca795a3116be2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ntp_snippets/features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
vitaliii
[1 line CL] Hi jkrcal@, could you have a look please?
3 years, 10 months ago (2017-02-24 12:14:16 UTC) #2
jkrcal
lgtm
3 years, 10 months ago (2017-02-24 12:23:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719473002/1
3 years, 10 months ago (2017-02-24 12:24:53 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 13:04:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ea3b8e1f7c6738a53e11c4dc58c...

Powered by Google App Engine
This is Rietveld 408576698