Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2746363005: Revert of Null check for IME descriptor in GetKeyboardLayoutsForResovledLocale (Closed)

Created:
3 years, 9 months ago by tbarzic
Modified:
3 years, 9 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Null check for IME descriptor in GetKeyboardLayoutsForResovledLocale (patchset #3 id:40001 of https://codereview.chromium.org/2756523003/ ) Reason for revert: landed a better workaround Original issue's description: > Null check for IME descriptor in GetKeyboardLayoutsForResovledLocale > > This is workaround for layouts returned by GetHardwareInputMethodIds > not having a valid IME descriptor. > > BUG=700625 > > Review-Url: https://codereview.chromium.org/2756523003 > Cr-Commit-Position: refs/heads/master@{#457228} > Committed: https://chromium.googlesource.com/chromium/src/+/a6ba05eb3482758392c1e440f853f4e612140122 TBR=alemate@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700625 Review-Url: https://codereview.chromium.org/2746363005 Cr-Commit-Position: refs/heads/master@{#457343} Committed: https://chromium.googlesource.com/chromium/src/+/cc4fa24df64468cb490a6247534cf79a2e4698cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tbarzic
Created Revert of Null check for IME descriptor in GetKeyboardLayoutsForResovledLocale
3 years, 9 months ago (2017-03-16 03:59:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746363005/1
3 years, 9 months ago (2017-03-16 03:59:54 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 04:01:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc4fa24df64468cb490a6247534c...

Powered by Google App Engine
This is Rietveld 408576698