Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2756523003: Null check for IME descriptor in GetKeyboardLayoutsForResovledLocale (Closed)

Created:
3 years, 9 months ago by tbarzic
Modified:
3 years, 9 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Null check for IME descriptor in GetKeyboardLayoutsForResovledLocale This is workaround for layouts returned by GetHardwareInputMethodIds not having a valid IME descriptor. BUG=700625 Review-Url: https://codereview.chromium.org/2756523003 Cr-Commit-Position: refs/heads/master@{#457228} Committed: https://chromium.googlesource.com/chromium/src/+/a6ba05eb3482758392c1e440f853f4e612140122

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
tbarzic
3 years, 9 months ago (2017-03-15 20:17:26 UTC) #4
Alexander Alekseev
lgtm
3 years, 9 months ago (2017-03-15 20:35:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756523003/40001
3 years, 9 months ago (2017-03-15 21:59:26 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a6ba05eb3482758392c1e440f853f4e612140122
3 years, 9 months ago (2017-03-15 22:11:28 UTC) #16
tbarzic
3 years, 9 months ago (2017-03-16 03:59:17 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2746363005/ by tbarzic@chromium.org.

The reason for reverting is: landed a better workaround.

Powered by Google App Engine
This is Rietveld 408576698