Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2746113002: platform/loader: move network/Resource* to loader/fetch (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tzik, fs, dcheng, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, krit, awdf+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, falken+watch_chromium.org, pdr+svgwatchlist_chromium.org, blink-worker-reviews_chromium.org, blink-reviews-style_chromium.org, Peter Beverloo, Yoav Weiss, nhiroki, loading-reviews_chromium.org, lushnikov+blink_chromium.org, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, Stephen Chennney, michaeln, shimazu+serviceworker_chromium.org, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, mlamouri+watch-blink_chromium.org, serviceworker-reviews, loading-reviews+parser_chromium.org, fmalita+watch_chromium.org, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews-frames_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

platform/loader: move network/Resource* to loader/fetch Since network/Resource* are utilities for loader/fetch/ResourceLoader, it would be more reasonable to have them in loader/fetch/ rather than network/. BUG=699369 Review-Url: https://codereview.chromium.org/2746113002 Cr-Commit-Position: refs/heads/master@{#457056} Committed: https://chromium.googlesource.com/chromium/src/+/15e3d9216e921042d06c0b6aaadcea10101d1034

Patch Set 1 #

Patch Set 2 : git rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -3364 lines) Patch
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameClient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveListTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSource.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/DevToolsHost.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoadRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/HistoryItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTrackerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/private/CrossOriginPreflightResultCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResourceTest.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResourceContent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResourceObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParserTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceTiming.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BlobBytesConsumerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 3 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebHTTPLoadInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLLoadTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/BUILD.gn View 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControlTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/MemoryCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/RawResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceError.h View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceError.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceLoadInfo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceLoadPriority.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceLoadTiming.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceLoadTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceRequestTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceResponseTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/testing/FetchTestingPlatformSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ContentSecurityPolicyResponseHeaders.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsersTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkInstrumentation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceError.h View 1 chunk +0 lines, -159 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceError.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceLoadInfo.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceLoadPriority.h View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceLoadTiming.h View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceLoadTiming.cpp View 1 chunk +0 lines, -142 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceRequest.h View 1 chunk +0 lines, -417 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceRequest.cpp View 1 chunk +0 lines, -425 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 chunk +0 lines, -550 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceResponse.cpp View 1 chunk +0 lines, -643 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceResponseTest.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceTimingInfo.h View 1 1 chunk +0 lines, -157 lines 0 comments Download
D third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp View 1 1 chunk +0 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAssociatedURLLoaderImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (16 generated)
Takashi Toyoshima
PTAL
3 years, 9 months ago (2017-03-15 00:42:21 UTC) #3
kinuko
lgtm
3 years, 9 months ago (2017-03-15 01:13:39 UTC) #4
kouhei (in TOK)
lgtm
3 years, 9 months ago (2017-03-15 01:15:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746113002/1
3 years, 9 months ago (2017-03-15 02:47:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/327056) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-15 02:53:03 UTC) #10
Takashi Toyoshima
+haraken for web and modules
3 years, 9 months ago (2017-03-15 03:33:21 UTC) #12
Takashi Toyoshima
also will upload a rebased patch set (patch failed in the CQ)
3 years, 9 months ago (2017-03-15 03:34:43 UTC) #13
haraken
LGTM
3 years, 9 months ago (2017-03-15 07:31:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746113002/20001
3 years, 9 months ago (2017-03-15 08:21:02 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/383948)
3 years, 9 months ago (2017-03-15 10:04:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746113002/20001
3 years, 9 months ago (2017-03-15 11:15:15 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 12:05:45 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15e3d9216e921042d06c0b6aaadc...

Powered by Google App Engine
This is Rietveld 408576698