Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2746093002: Remove obsolete methods from GenericURLRequestJob::Delegate (Closed)

Created:
3 years, 9 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete methods from GenericURLRequestJob::Delegate BUG=546953 Review-Url: https://codereview.chromium.org/2746093002 Cr-Commit-Position: refs/heads/master@{#456352} Committed: https://chromium.googlesource.com/chromium/src/+/2f49bc490fc420fb5ac0172080cc92c09da8bbf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -59 lines) Patch
M headless/public/util/generic_url_request_job.h View 2 chunks +3 lines, -17 lines 0 comments Download
M headless/public/util/generic_url_request_job.cc View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
alex clarke (OOO till 29th)
3 years, 9 months ago (2017-03-13 10:53:46 UTC) #2
Sami
lgtm yay
3 years, 9 months ago (2017-03-13 11:18:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746093002/1
3 years, 9 months ago (2017-03-13 11:19:01 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 11:31:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f49bc490fc420fb5ac0172080cc...

Powered by Google App Engine
This is Rietveld 408576698