Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: headless/public/util/generic_url_request_job.h

Issue 2746093002: Remove obsolete methods from GenericURLRequestJob::Delegate (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | headless/public/util/generic_url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/util/generic_url_request_job.h
diff --git a/headless/public/util/generic_url_request_job.h b/headless/public/util/generic_url_request_job.h
index 1bb0890553121e09d2b7797c0f958ae34384876d..751f497c66ab7c8a014ba2c9d4b89be150c93578 100644
--- a/headless/public/util/generic_url_request_job.h
+++ b/headless/public/util/generic_url_request_job.h
@@ -61,12 +61,7 @@ class GenericURLRequestJob : public ManagedDispatchURLRequestJob,
const std::string& devtools_id,
const std::string& method,
const std::string& referrer,
- RewriteCallback callback);
- // TODO(alexclarke): Make the above pure virtual and remove this.
- virtual bool BlockOrRewriteRequest(const GURL& url,
- const std::string& method,
- const std::string& referrer,
- RewriteCallback callback);
+ RewriteCallback callback) = 0;
// Allows the delegate to synchronously fulfill a request with a reply.
// Called on an arbitrary thread.
@@ -74,22 +69,13 @@ class GenericURLRequestJob : public ManagedDispatchURLRequestJob,
const GURL& url,
const std::string& devtools_id,
const std::string& method,
- const net::HttpRequestHeaders& request_headers);
- // TODO(alexclarke): Make the above pure virtual and remove this.
- virtual const HttpResponse* MaybeMatchResource(
- const GURL& url,
- const std::string& method,
- const net::HttpRequestHeaders& request_headers);
+ const net::HttpRequestHeaders& request_headers) = 0;
// Signals that a resource load has finished. Called on an arbitrary thread.
virtual void OnResourceLoadComplete(const GURL& final_url,
const std::string& devtools_id,
const std::string& mime_type,
- int http_response_code);
- // TODO(alexclarke): Make the above pure virtual and remove this.
- virtual void OnResourceLoadComplete(const GURL& final_url,
- const std::string& mime_type,
- int http_response_code) {}
+ int http_response_code) = 0;
protected:
virtual ~Delegate() {}
« no previous file with comments | « no previous file | headless/public/util/generic_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698