[Home] Add BottomSheetObserverTest#testSheetContentChanged

[Home] Add BottomSheetObserverTest#testSheetContentChanged

BUG=699598
Review-Url: https://codereview.chromium.org/2746013011
Cr-Commit-Position: refs/heads/master@{#458755}
Committed: https://chromium.googlesource.com/chromium/src/+/b25d9bc963bc1b4037024a4eb4eadd1afb7f7155

[Theresa, 2017-03-17 21:41:25]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 21:42:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-03-17 21:44:59]

twellington@chromium.org changed reviewers:
+ mdjones@chromium.org

[Theresa, 2017-03-17 21:45:00]

ptal

[mdjones, 2017-03-17 22:13:12]

lgtm

[commit-bot: I haz the power, 2017-03-17 23:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:36:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Theresa, 2017-03-20 20:19:53]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 20:20:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 21:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:43:12]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-03-20 23:36:33]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:37:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:52:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Theresa, 2017-03-21 00:36:11]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 00:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-03-21 00:37:27]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2017-03-21 00:37:28]

+dfalcantara@ for chrome/test/android/OWNERS

[commit-bot: I haz the power, 2017-03-21 00:42:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 00:42:34]

Dry run: This issue passed the CQ dry run.

[gone, 2017-03-21 17:46:52]

lgtm

https://codereview.chromium.org/2746013011/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2746013011/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:653: *
@return The bottom sheet content controller or null.
Should probably just use {@link BottomSheetContentController} or something.

https://codereview.chromium.org/2746013011/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
(right):

https://codereview.chromium.org/2746013011/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java:193:
public void selectItem(int itemId) {
If this is only meant for testing, call it that so no one else calls it.

selectItemForTests

https://codereview.chromium.org/2746013011/diff/1/chrome/test/android/javates...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/BottomSheetTestCaseBase.java
(right):

https://codereview.chromium.org/2746013011/diff/1/chrome/test/android/javates...
chrome/test/android/javatests/src/org/chromium/chrome/test/BottomSheetTestCaseBase.java:29:
/** A handle to the bottom seet content controller. */
sheet, or use the real class name

[Theresa, 2017-03-21 22:29:25]

https://codereview.chromium.org/2746013011/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2746013011/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:653: *
@return The bottom sheet content controller or null.
On 2017/03/21 17:46:51, dfalcantara (load balance plz) wrote:
> Should probably just use {@link BottomSheetContentController} or something.

Done.

https://codereview.chromium.org/2746013011/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
(right):

https://codereview.chromium.org/2746013011/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java:193:
public void selectItem(int itemId) {
On 2017/03/21 17:46:51, dfalcantara (load balance plz) wrote:
> If this is only meant for testing, call it that so no one else calls it.
> 
> selectItemForTests

Done.

https://codereview.chromium.org/2746013011/diff/1/chrome/test/android/javates...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/BottomSheetTestCaseBase.java
(right):

https://codereview.chromium.org/2746013011/diff/1/chrome/test/android/javates...
chrome/test/android/javatests/src/org/chromium/chrome/test/BottomSheetTestCaseBase.java:29:
/** A handle to the bottom seet content controller. */
On 2017/03/21 17:46:51, dfalcantara (load balance plz) wrote:
> sheet, or use the real class name

Done.

[Theresa, 2017-03-21 22:29:40]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 22:30:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 23:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:19:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Theresa, 2017-03-21 23:25:55]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 23:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 00:12:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:12:35]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-03-22 15:22:41]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2017-03-22 15:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
mdjones@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2746013011/#ps20001
(title: "[Home] Add BottomSheetObserverTest#testSheetContentChanged")

[commit-bot: I haz the power, 2017-03-22 15:23:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 15:27:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490196161937330,
"parent_rev": "96dd5df887ad492d2da843329098474fb8f8d5d6", "commit_rev":
"b25d9bc963bc1b4037024a4eb4eadd1afb7f7155"}

[commit-bot: I haz the power, 2017-03-22 15:27:59]

Description was changed from

==========
[Home] Add BottomSheetObserverTest#testSheetContentChanged

BUG=699598
==========

to

==========
[Home] Add BottomSheetObserverTest#testSheetContentChanged

BUG=699598

Review-Url: https://codereview.chromium.org/2746013011
Cr-Commit-Position: refs/heads/master@{#458755}
Committed:
https://chromium.googlesource.com/chromium/src/+/b25d9bc963bc1b4037024a4eb4ea...
==========

[commit-bot: I haz the power, 2017-03-22 15:28:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b25d9bc963bc1b4037024a4eb4ea...