Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java

Issue 2746013011: [Home] Add BottomSheetObserverTest#testSheetContentChanged (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.widget.bottomsheet; 5 package org.chromium.chrome.browser.widget.bottomsheet;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.content.res.Resources; 8 import android.content.res.Resources;
9 import android.support.annotation.IntDef; 9 import android.support.annotation.IntDef;
10 import android.support.design.internal.BottomNavigationItemView; 10 import android.support.design.internal.BottomNavigationItemView;
11 import android.support.design.internal.BottomNavigationMenuView; 11 import android.support.design.internal.BottomNavigationMenuView;
12 import android.support.design.widget.BottomNavigationView; 12 import android.support.design.widget.BottomNavigationView;
13 import android.support.design.widget.BottomNavigationView.OnNavigationItemSelect edListener; 13 import android.support.design.widget.BottomNavigationView.OnNavigationItemSelect edListener;
14 import android.util.AttributeSet; 14 import android.util.AttributeSet;
15 import android.view.MenuItem; 15 import android.view.MenuItem;
16 import android.view.View; 16 import android.view.View;
17 17
18 import org.chromium.base.VisibleForTesting;
18 import org.chromium.chrome.R; 19 import org.chromium.chrome.R;
19 import org.chromium.chrome.browser.bookmarks.BookmarkSheetContent; 20 import org.chromium.chrome.browser.bookmarks.BookmarkSheetContent;
20 import org.chromium.chrome.browser.download.DownloadSheetContent; 21 import org.chromium.chrome.browser.download.DownloadSheetContent;
21 import org.chromium.chrome.browser.history.HistorySheetContent; 22 import org.chromium.chrome.browser.history.HistorySheetContent;
22 import org.chromium.chrome.browser.suggestions.SuggestionsBottomSheetContent; 23 import org.chromium.chrome.browser.suggestions.SuggestionsBottomSheetContent;
23 import org.chromium.chrome.browser.tabmodel.TabModelSelector; 24 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
24 import org.chromium.chrome.browser.util.MathUtils; 25 import org.chromium.chrome.browser.util.MathUtils;
25 import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet.BottomSheetCon tent; 26 import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet.BottomSheetCon tent;
26 27
27 import java.lang.annotation.Retention; 28 import java.lang.annotation.Retention;
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 private void showBottomSheetContent(int navItemId) { 178 private void showBottomSheetContent(int navItemId) {
178 // There are some bugs related to programatically selecting menu items t hat are fixed in 179 // There are some bugs related to programatically selecting menu items t hat are fixed in
179 // newer support library versions. 180 // newer support library versions.
180 // TODO(twellington): remove this after the support library is rolled. 181 // TODO(twellington): remove this after the support library is rolled.
181 if (mSelectedItemId != 0) getMenu().findItem(mSelectedItemId).setChecked (false); 182 if (mSelectedItemId != 0) getMenu().findItem(mSelectedItemId).setChecked (false);
182 mSelectedItemId = navItemId; 183 mSelectedItemId = navItemId;
183 getMenu().findItem(mSelectedItemId).setChecked(true); 184 getMenu().findItem(mSelectedItemId).setChecked(true);
184 185
185 mBottomSheet.showContent(getSheetContentForId(mSelectedItemId)); 186 mBottomSheet.showContent(getSheetContentForId(mSelectedItemId));
186 } 187 }
188
189 /**
190 * @param itemId The id of the MenuItem to select.
191 */
192 @VisibleForTesting
193 public void selectItem(int itemId) {
gone 2017/03/21 17:46:51 If this is only meant for testing, call it that so
Theresa 2017/03/21 22:29:24 Done.
194 // TODO(twellington): A #setSelectedItemId() method was added to the sup port library
195 // recently. Replace this custom implementation with that method after
196 // the support library is rolled.
197 onNavigationItemSelected(getMenu().findItem(itemId));
198 }
187 } 199 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698