Rework SMIL animation target invalidation

Rework SMIL animation target invalidation

The invalidation of a timed/animation element's target "tuple" (element,
attribute name, attribute type) is somewhat complex.
Rework it to use two methods that can be overridden rather than having
overrides for each setTargetElement/setAttribute{Name,Type}. This allows
to get rid of complicated things like the checkInvalidCSSAttributeType()
in SVGAnimateElement. It should also make the code slightly easier to
reason about when it comes to what state gets invalidated where.

BUG=641437, 701128
Review-Url: https://codereview.chromium.org/2746013007
Cr-Commit-Position: refs/heads/master@{#457972}
Committed: https://chromium.googlesource.com/chromium/src/+/c2aeb3453198b951cf00a6883783461d2752f29e

[fs, 2017-03-15 17:36:27]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 17:37:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 18:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 18:55:00]

Dry run: This issue passed the CQ dry run.

[fs, 2017-03-15 19:22:24]

Description was changed from

==========
Rework animation target invalidation

BUG=641437,701128
==========

to

==========
Rework SMIL animation target invalidation

The invalidation of a timed/animation element's target "tuple" (element,
attribute name, attribute type) is somewhat complex.
Rework it to use two methods that can be overridden rather than having
overrides for each setTargetElement/setAttribute{Name,Type}. This allows
to get rid of complicated things like the checkInvalidCSSAttributeType()
in SVGAnimateElement. It should also make the code slightly easier to
reason about when it comes to what state gets invalidated where.

BUG=641437,701128
==========

[fs, 2017-03-15 19:22:24]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[pdr., 2017-03-17 22:08:35]

On 2017/03/17 at 15:36:35, fs wrote:
> 

LGTM

[fs, 2017-03-18 13:06:55]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-03-18 13:07:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 14:36:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 14:36:06]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-03-18 16:57:03]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-03-18 16:57:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 17:00:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489856223712650, "parent_rev":
"9b806ab221956979391d7d1974c6ea434c7f1752", "commit_rev":
"c2aeb3453198b951cf00a6883783461d2752f29e"}

[commit-bot: I haz the power, 2017-03-18 17:01:05]

Description was changed from

==========
Rework SMIL animation target invalidation

The invalidation of a timed/animation element's target "tuple" (element,
attribute name, attribute type) is somewhat complex.
Rework it to use two methods that can be overridden rather than having
overrides for each setTargetElement/setAttribute{Name,Type}. This allows
to get rid of complicated things like the checkInvalidCSSAttributeType()
in SVGAnimateElement. It should also make the code slightly easier to
reason about when it comes to what state gets invalidated where.

BUG=641437,701128
==========

to

==========
Rework SMIL animation target invalidation

The invalidation of a timed/animation element's target "tuple" (element,
attribute name, attribute type) is somewhat complex.
Rework it to use two methods that can be overridden rather than having
overrides for each setTargetElement/setAttribute{Name,Type}. This allows
to get rid of complicated things like the checkInvalidCSSAttributeType()
in SVGAnimateElement. It should also make the code slightly easier to
reason about when it comes to what state gets invalidated where.

BUG=641437,701128

Review-Url: https://codereview.chromium.org/2746013007
Cr-Commit-Position: refs/heads/master@{#457972}
Committed:
https://chromium.googlesource.com/chromium/src/+/c2aeb3453198b951cf00a6883783...
==========

[commit-bot: I haz the power, 2017-03-18 17:01:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2aeb3453198b951cf00a6883783...