Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.h

Issue 2746013007: Rework SMIL animation target invalidation (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGAnimateElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateElement.h b/third_party/WebKit/Source/core/svg/SVGAnimateElement.h
index 63925225ca7e9a7af57b31330e1f30ed70fa8c21..7162cb9069291e7e6ac11066f54f22aab855531b 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimateElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGAnimateElement.h
@@ -56,6 +56,9 @@ class CORE_EXPORT SVGAnimateElement : public SVGAnimationElement {
bool hasValidTarget() override;
+ void willChangeAnimationTarget() final;
+ void didChangeAnimationTarget() final;
+
void resetAnimatedType() final;
void clearAnimatedType() final;
@@ -75,7 +78,6 @@ class CORE_EXPORT SVGAnimateElement : public SVGAnimationElement {
void parseAttribute(const AttributeModificationParams&) override;
- void setTargetElement(SVGElement*) final;
void setAttributeName(const QualifiedName&);
enum AttributeType { AttributeTypeCSS, AttributeTypeXML, AttributeTypeAuto };
@@ -95,9 +97,6 @@ class CORE_EXPORT SVGAnimateElement : public SVGAnimationElement {
InsertionNotificationRequest insertedInto(ContainerNode*) final;
void removedFrom(ContainerNode*) final;
- void checkInvalidCSSAttributeType();
- bool hasValidAttributeName() const;
-
virtual void resolveTargetProperty();
void clearTargetProperty();
@@ -127,7 +126,6 @@ class CORE_EXPORT SVGAnimateElement : public SVGAnimationElement {
AnimatedPropertyValueType m_fromPropertyValueType;
AnimatedPropertyValueType m_toPropertyValueType;
AttributeType m_attributeType;
- bool m_hasInvalidCSSAttributeType;
};
inline bool isSVGAnimateElement(const SVGElement& element) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698