third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js - Issue 2745903003: [DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

Issue 2745903003: [DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper. (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

index 4194f9928b62ef0e871a20f9196b91f6feab6442..4a22228868b2d32da6c1cc5115b8b0732b4acfaa 100644

--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

@@ -76,7 +76,7 @@ PerfUI.TimelineOverviewPane = class extends UI.VBox {

}

/**

- * @param {!Element} anchor

+ * @param {!Element|!AnchorBox} anchor

* @param {!UI.GlassPane} popover

* @return {!Promise<boolean>}