Add targetsAtLeastO() helper function

Add targetsAtLeastO() helper function

This adds the targetsAtLeastO() helper function to BuildInfo. I also
updated the check we were using for HTTPS clear text to use this
instead of manually checking targetSdkVersion.

This helper should be updated once the SDK level for O has been
finalized.

BUG=688556
Review-Url: https://codereview.chromium.org/2745663002
Cr-Commit-Position: refs/heads/master@{#456128}
Committed: https://chromium.googlesource.com/chromium/src/+/5f8b72e3c433990df81374e7a68144069da8d7d9

[Nate Fischer, 2017-03-09 23:13:55]

ntfschr@chromium.org changed reviewers:
+ torne@chromium.org

[Nate Fischer, 2017-03-09 23:13:56]

PTAL

Follow up from the discussion at https://codereview.chromium.org/2739003002

[Nate Fischer, 2017-03-09 23:39:24]

On 2017/03/09 at 23:13:56, Nate Fischer wrote:
> PTAL
> 
> Follow up from the discussion at https://codereview.chromium.org/2739003002

I verified this by modifying targetSdkVersion in shell browser's manifest XML:

 - targetSdkVersion="10000" -> targetsAtLeastO() == true
 - targetSdkVersion="O"     -> targetsAtLeastO() == true
 - targetSdkVersion="26"    -> targetsAtLeastO() == false

Any other steps I should do to verify this?

[Nate Fischer, 2017-03-09 23:40:19]

ntfschr@chromium.org changed reviewers:
+ sgurun@chromium.org

[Nate Fischer, 2017-03-09 23:41:56]

sgurun@: is it ok for me to make the change here for cleartext? Just want to
make sure you aren't depending on this working for targetSdkVersion="26" (this
change would require targetSdkVersion="O" or "10000").

[sgurun-gerrit only, 2017-03-10 00:24:07]

On 2017/03/09 23:41:56, Nate Fischer wrote:
> sgurun@: is it ok for me to make the change here for cleartext? Just want to
> make sure you aren't depending on this working for targetSdkVersion="26" (this
> change would require targetSdkVersion="O" or "10000").

aw lgtm

[Torne, 2017-03-10 11:10:56]

lgtm

[Nate Fischer, 2017-03-10 18:06:51]

The CQ bit was checked by ntfschr@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:07:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 19:17:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489169211830330, "parent_rev":
"d3d4d93c503aa6b59908bb7bda912bd22a7fd1fa", "commit_rev":
"5f8b72e3c433990df81374e7a68144069da8d7d9"}

[commit-bot: I haz the power, 2017-03-10 19:18:18]

Description was changed from

==========
Add targetsAtLeastO() helper function

This adds the targetsAtLeastO() helper function to BuildInfo. I also
updated the check we were using for HTTPS clear text to use this
instead of manually checking targetSdkVersion.

This helper should be updated once the SDK level for O has been
finalized.

BUG=688556
==========

to

==========
Add targetsAtLeastO() helper function

This adds the targetsAtLeastO() helper function to BuildInfo. I also
updated the check we were using for HTTPS clear text to use this
instead of manually checking targetSdkVersion.

This helper should be updated once the SDK level for O has been
finalized.

BUG=688556

Review-Url: https://codereview.chromium.org/2745663002
Cr-Commit-Position: refs/heads/master@{#456128}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f8b72e3c433990df81374e7a681...
==========

[commit-bot: I haz the power, 2017-03-10 19:18:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f8b72e3c433990df81374e7a681...