Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2102)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Issue 2745663002: Add targetsAtLeastO() helper function (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/BuildInfo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
index 70436742bdb5cc232a1e9b74d86cd5def5d75c30..38e1d99bb82ed9b87c73ebbf96455469622de076 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
@@ -335,10 +335,7 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {
new AwNetworkChangeNotifierRegistrationPolicy());
}
- int targetSdkVersion = applicationContext.getApplicationInfo().targetSdkVersion;
- // TODO(sgurun) We need to change this to > N_MR1 when we roll N_MR1 sdk or
- // >= O when we roll O SDK to upstream. crbug/688556
- AwContentsStatics.setCheckClearTextPermitted(targetSdkVersion > 25);
+ AwContentsStatics.setCheckClearTextPermitted(BuildInfo.targetsAtLeastO(applicationContext));
}
private void ensureChromiumStartedLocked(boolean onMainThread) {
« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/BuildInfo.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698