Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2745653012: enable/disable default package contributed analysis options (Closed)

Created:
3 years, 9 months ago by danrubel
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

enable/disable default package contributed analysis options This adds an option to enable or disable (enabled by default) package contributed default analysis options. If an analysis options file is not explicitly specified via the "--options" option and an analysis options file cannot be found in the project directory or any parent directory, then look for analysis options in the following locations if this new option is enabled: - package:flutter/analysis_options_user.yaml - package:dart.analysis_options/default.yaml R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/090f4ca5b8ae4b9b66beac30e91208895528d9b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -18 lines) Patch
M pkg/analyzer/lib/src/command_line/arguments.dart View 3 chunks +22 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 3 chunks +26 lines, -17 lines 0 comments Download
M pkg/analyzer/test/src/command_line/arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
Fix https://github.com/dart-lang/sdk/issues/29042
3 years, 9 months ago (2017-03-11 20:52:50 UTC) #2
Brian Wilkerson
lgtm Is this a long term solution, or a short-term work around?
3 years, 9 months ago (2017-03-11 22:16:33 UTC) #3
danrubel
3 years, 9 months ago (2017-03-12 17:31:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
090f4ca5b8ae4b9b66beac30e91208895528d9b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698