Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: pkg/analyzer/lib/src/command_line/arguments.dart

Issue 2745653012: enable/disable default package contributed analysis options (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/context/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/command_line/arguments.dart
diff --git a/pkg/analyzer/lib/src/command_line/arguments.dart b/pkg/analyzer/lib/src/command_line/arguments.dart
index 5579005fc7999454e43c73bedd121377bd69c18e..10bd00c2279065d854c758983f6721681adcc931 100644
--- a/pkg/analyzer/lib/src/command_line/arguments.dart
+++ b/pkg/analyzer/lib/src/command_line/arguments.dart
@@ -23,12 +23,18 @@ const String ignoreUnrecognizedFlagsFlag = 'ignore-unrecognized-flags';
const String lintsFlag = 'lints';
const String noImplicitCastsFlag = 'no-implicit-casts';
const String noImplicitDynamicFlag = 'no-implicit-dynamic';
+const String packageDefaultAnalysisOptions = 'package-default-analysis-options';
const String packageRootOption = 'package-root';
const String packagesOption = 'packages';
const String sdkPathOption = 'dart-sdk';
const String sdkSummaryPathOption = 'dart-sdk-summary';
const String strongModeFlag = 'strong';
+const String bazelAnalysisOptionsPath =
+ 'package:dart.analysis_options/default.yaml';
+const String flutterAnalysisOptionsPath =
+ 'package:flutter/analysis_options_user.yaml';
+
/**
* Update [options] with the value of each analysis option command line flag.
*/
@@ -87,6 +93,11 @@ ContextBuilderOptions createContextBuilderOptions(ArgResults args,
builderOptions.defaultPackageFilePath = args[packagesOption];
builderOptions.defaultPackagesDirectoryPath = args[packageRootOption];
//
+ // Flags.
+ //
+ builderOptions.packageDefaultAnalysisOptions =
+ args[packageDefaultAnalysisOptions];
+ //
// Analysis options.
//
AnalysisOptionsImpl defaultOptions = new AnalysisOptionsImpl();
@@ -179,6 +190,17 @@ void defineAnalysisArguments(ArgParser parser, {bool hide: true, ddc: false}) {
help: 'Define environment variables. For example, "-Dfoo=bar" defines an '
'environment variable named "foo" whose value is "bar".',
hide: hide);
+ parser.addFlag(packageDefaultAnalysisOptions,
+ help: 'If an analysis options file is not explicitly specified '
+ 'via the "--$analysisOptionsFileOption" option\n'
+ 'and an analysis options file cannot be found '
+ 'in the project directory or any parent directory,\n'
+ 'then look for analysis options in the following locations:\n'
+ '- $flutterAnalysisOptionsPath\n'
+ '- $bazelAnalysisOptionsPath',
+ defaultsTo: true,
+ negatable: true,
+ hide: hide);
parser.addOption(packagesOption,
help: 'The path to the package resolution configuration file, which '
'supplies a mapping of package names\nto paths. This option cannot be '
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/context/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698