Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: pkg/analyzer/test/src/context/builder_test.dart

Issue 2745653012: enable/disable default package contributed analysis options (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/command_line/arguments_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/context/builder_test.dart
diff --git a/pkg/analyzer/test/src/context/builder_test.dart b/pkg/analyzer/test/src/context/builder_test.dart
index 853adbdd393b53e57b09e1d8248b7c12d7e425f8..a139090a7f3383c01b3431fb1daf912a89ffd3ed 100644
--- a/pkg/analyzer/test/src/context/builder_test.dart
+++ b/pkg/analyzer/test/src/context/builder_test.dart
@@ -739,6 +739,37 @@ linter:
_expectEqualOptions(options, expected);
}
+ void test_getAnalysisOptions_default_flutter_disabled() {
+ _defineMockLintRules();
+ ArgParser argParser = new ArgParser();
+ defineAnalysisArguments(argParser);
+ ArgResults argResults =
+ argParser.parse(['--no-$packageDefaultAnalysisOptions']);
+
+ builderOptions = createContextBuilderOptions(argResults);
+ expect(builderOptions.packageDefaultAnalysisOptions, isFalse);
+ builder = new ContextBuilder(resourceProvider, sdkManager, contentCache,
+ options: builderOptions);
+
+ AnalysisOptionsImpl expected = new AnalysisOptionsImpl();
+
+ String packagesFilePath =
+ resourceProvider.convertPath('/some/directory/path/.packages');
+ createFile(packagesFilePath, 'flutter:/pkg/flutter/lib/');
+ String optionsFilePath = resourceProvider
+ .convertPath('/pkg/flutter/lib/analysis_options_user.yaml');
+ createFile(
+ optionsFilePath,
+ '''
+linter:
+ rules:
+ - mock_lint_rule
+''');
+ String projPath = resourceProvider.convertPath('/some/directory/path');
+ AnalysisOptions options = builder.getAnalysisOptions(projPath);
+ _expectEqualOptions(options, expected);
+ }
+
void test_getAnalysisOptions_default_noOverrides() {
AnalysisOptionsImpl defaultOptions = new AnalysisOptionsImpl();
defaultOptions.enableLazyAssignmentOperators = true;
« no previous file with comments | « pkg/analyzer/test/src/command_line/arguments_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698