Fix the browser not being notified when a webview embedder handles a navigation.

Fix the browser not being notified when a webview embedder handles a navigation.

This ended up causing browser code to not get the notification that a navigation completed.

This fixes
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden with {--webview-sandboxed-renderer}
with PlzNavigate

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2745653011
Cr-Commit-Position: refs/heads/master@{#456407}
Committed: https://chromium.googlesource.com/chromium/src/+/761cdd9d8d97595aef3302c952cb73a63c3aa75f

[jam, 2017-03-11 01:15:39]

Description was changed from

==========
Fix ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden

BUG=
==========

to

==========
Fix ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-03-11 01:19:28]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 01:19:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-11 01:21:50]

Description was changed from

==========
Fix ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix the browser not being notified when a webview embedder handles a navigation.

This ended up causing browser code to not get the notification that a navigation
completed.

This fixes
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden with
{--webview-sandboxed-renderer}
with PlzNavigate

BUG=645983
==========

[jam, 2017-03-11 01:21:51]

jam@chromium.org changed reviewers:
+ sgurun@chromium.org

[commit-bot: I haz the power, 2017-03-11 01:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 01:25:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-03-11 01:30:25]

Description was changed from

==========
Fix the browser not being notified when a webview embedder handles a navigation.

This ended up causing browser code to not get the notification that a navigation
completed.

This fixes
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden with
{--webview-sandboxed-renderer}
with PlzNavigate

BUG=645983
==========

to

==========
Fix the browser not being notified when a webview embedder handles a navigation.

This ended up causing browser code to not get the notification that a navigation
completed.

This fixes
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden with
{--webview-sandboxed-renderer}
with PlzNavigate

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-03-11 01:32:05]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 01:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 02:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:15:03]

Dry run: This issue passed the CQ dry run.

[sgurun-gerrit only, 2017-03-11 02:33:40]

https://codereview.chromium.org/2745653011/diff/60001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2745653011/diff/60001/content/renderer/render...
content/renderer/render_frame_impl.cc:5269: Send(new
FrameHostMsg_NavigationHandledByEmbedder(routing_id_));
I wonder if there is a better way to do this. We wanted to remove this code as
it is only used for Webview's shouldoverrideurlloading, see
https://cs.chromium.org/chromium/src/android_webview/renderer/aw_content_rend...

[jam, 2017-03-11 04:06:54]

Patchset #2 (id:20001) has been deleted

[jam, 2017-03-11 04:06:59]

Patchset #1 (id:1) has been deleted

[jam, 2017-03-11 05:13:24]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 05:13:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-11 05:15:07]

https://codereview.chromium.org/2745653011/diff/60001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2745653011/diff/60001/content/renderer/render...
content/renderer/render_frame_impl.cc:5269: Send(new
FrameHostMsg_NavigationHandledByEmbedder(routing_id_));
On 2017/03/11 02:33:40, sgurun wrote:
> I wonder if there is a better way to do this. We wanted to remove this code as
> it is only used for Webview's shouldoverrideurlloading, see
>
https://cs.chromium.org/chromium/src/android_webview/renderer/aw_content_rend...

Seems like the question of when it's ok to remove this is orthogonal from this
fix? If you have any better suggestions for how to fix this API with PlzNavigate
though I'm all ears.

[commit-bot: I haz the power, 2017-03-11 06:27:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 06:27:30]

Dry run: This issue passed the CQ dry run.

[sgurun-gerrit only, 2017-03-13 15:52:12]

On 2017/03/11 05:15:07, jam wrote:
>
https://codereview.chromium.org/2745653011/diff/60001/content/renderer/render...
> File content/renderer/render_frame_impl.cc (right):
> 
>
https://codereview.chromium.org/2745653011/diff/60001/content/renderer/render...
> content/renderer/render_frame_impl.cc:5269: Send(new
> FrameHostMsg_NavigationHandledByEmbedder(routing_id_));
> On 2017/03/11 02:33:40, sgurun wrote:
> > I wonder if there is a better way to do this. We wanted to remove this code
as
> > it is only used for Webview's shouldoverrideurlloading, see
> >
>
https://cs.chromium.org/chromium/src/android_webview/renderer/aw_content_rend...
> 
> Seems like the question of when it's ok to remove this is orthogonal from this
> fix? If you have any better suggestions for how to fix this API with
PlzNavigate
> though I'm all ears.

lgtm

[jam, 2017-03-13 16:00:41]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:01:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 16:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:08:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2017-03-13 16:24:30]

jam@chromium.org changed reviewers:
+ wfh@chromium.org

[jam, 2017-03-13 16:24:31]

+wfh for frame_messages.h

[Will Harris, 2017-03-13 16:28:09]

lgtm

[jam, 2017-03-13 17:03:41]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:04:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 17:08:57]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489424621211860,
"parent_rev": "006bbe06807819b9eca0d17a926ee09903ac0469", "commit_rev":
"761cdd9d8d97595aef3302c952cb73a63c3aa75f"}

[commit-bot: I haz the power, 2017-03-13 17:09:37]

Description was changed from

==========
Fix the browser not being notified when a webview embedder handles a navigation.

This ended up causing browser code to not get the notification that a navigation
completed.

This fixes
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden with
{--webview-sandboxed-renderer}
with PlzNavigate

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix the browser not being notified when a webview embedder handles a navigation.

This ended up causing browser code to not get the notification that a navigation
completed.

This fixes
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden
ClientOnPageFinishedTest#testCalledAfterRedirectedUrlIsOverridden with
{--webview-sandboxed-renderer}
with PlzNavigate

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2745653011
Cr-Commit-Position: refs/heads/master@{#456407}
Committed:
https://chromium.googlesource.com/chromium/src/+/761cdd9d8d97595aef3302c952cb...
==========

[commit-bot: I haz the power, 2017-03-13 17:09:38]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/761cdd9d8d97595aef3302c952cb...