Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2745653011: Fix the browser not being notified when a webview embedder handles a navigation. (Closed)
Patch Set: without PlzNavigate Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 5246 matching lines...) Expand 10 before | Expand all | Expand 10 after
5257 5257
5258 #ifdef OS_ANDROID 5258 #ifdef OS_ANDROID
5259 bool render_view_was_created_by_renderer = 5259 bool render_view_was_created_by_renderer =
5260 render_view_->was_created_by_renderer_; 5260 render_view_->was_created_by_renderer_;
5261 // The handlenavigation API is deprecated and will be removed once 5261 // The handlenavigation API is deprecated and will be removed once
5262 // crbug.com/325351 is resolved. 5262 // crbug.com/325351 is resolved.
5263 if (GetContentClient()->renderer()->HandleNavigation( 5263 if (GetContentClient()->renderer()->HandleNavigation(
5264 this, is_content_initiated, render_view_was_created_by_renderer, 5264 this, is_content_initiated, render_view_was_created_by_renderer,
5265 frame_, info.urlRequest, info.navigationType, info.defaultPolicy, 5265 frame_, info.urlRequest, info.navigationType, info.defaultPolicy,
5266 is_redirect)) { 5266 is_redirect)) {
5267 if (IsBrowserSideNavigationEnabled()) {
5268 // Need to let the browser know so it can notify its observers.
5269 Send(new FrameHostMsg_NavigationHandledByEmbedder(routing_id_));
5270 }
5267 return blink::WebNavigationPolicyIgnore; 5271 return blink::WebNavigationPolicyIgnore;
5268 } 5272 }
5269 #endif 5273 #endif
5270 5274
5271 Referrer referrer( 5275 Referrer referrer(
5272 RenderViewImpl::GetReferrerFromRequest(frame_, info.urlRequest)); 5276 RenderViewImpl::GetReferrerFromRequest(frame_, info.urlRequest));
5273 5277
5274 // Webkit is asking whether to navigate to a new URL. 5278 // Webkit is asking whether to navigate to a new URL.
5275 // This is fine normally, except if we're showing UI from one security 5279 // This is fine normally, except if we're showing UI from one security
5276 // context and they're trying to navigate to a different context. 5280 // context and they're trying to navigate to a different context.
(...skipping 1575 matching lines...) Expand 10 before | Expand all | Expand 10 after
6852 // event target. Potentially a Pepper plugin will receive the event. 6856 // event target. Potentially a Pepper plugin will receive the event.
6853 // In order to tell whether a plugin gets the last mouse event and which it 6857 // In order to tell whether a plugin gets the last mouse event and which it
6854 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6858 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6855 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6859 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6856 // |pepper_last_mouse_event_target_|. 6860 // |pepper_last_mouse_event_target_|.
6857 pepper_last_mouse_event_target_ = nullptr; 6861 pepper_last_mouse_event_target_ = nullptr;
6858 #endif 6862 #endif
6859 } 6863 }
6860 6864
6861 } // namespace content 6865 } // namespace content
OLDNEW
« no previous file with comments | « content/common/frame_messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698