Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2745623003: Revert of Fix TODOs related to SDK 24 (Closed)

Created:
3 years, 9 months ago by boliu
Modified:
3 years, 9 months ago
Reviewers:
Shimi Zhang, Torne
CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix TODOs related to SDK 24 (patchset #2 id:20001 of https://codereview.chromium.org/2738663003/ ) Reason for revert: BUG=699972 Original issue's description: > Fix TODOs related to SDK 24 > > Originally from Issue 2427543003 written by hush > > BUG=546762, 543272 > > Review-Url: https://codereview.chromium.org/2738663003 > Cr-Commit-Position: refs/heads/master@{#455347} > Committed: https://chromium.googlesource.com/chromium/src/+/299bf5a2daf2784c7cdd2917483733e2262efb55 TBR=torne@chromium.org,ctzsm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=546762, 543272 Review-Url: https://codereview.chromium.org/2745623003 Cr-Commit-Position: refs/heads/master@{#456094} Committed: https://chromium.googlesource.com/chromium/src/+/b579d0a779919583b7f77793d2f47a23eab9c1c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -11 lines) Patch
M android_webview/apk/java/proguard.flags View 1 chunk +6 lines, -0 lines 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java View 3 chunks +12 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +3 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 2 chunks +4 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
boliu
Created Revert of Fix TODOs related to SDK 24
3 years, 9 months ago (2017-03-10 17:00:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745623003/1
3 years, 9 months ago (2017-03-10 17:01:14 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 17:43:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b579d0a779919583b7f77793d2f4...

Powered by Google App Engine
This is Rietveld 408576698