android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 2745623003: Revert of Fix TODOs related to SDK 24

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 2745623003: Revert of Fix TODOs related to SDK 24 (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java ('k') | android_webview/java/src/org/chromium/android_webview/AwSettings.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index 561a0191fa7fb16b7a58a4d41e4b9c6ec12baf3b..6e5400008fc2ab43ef06e668f841e59adbc85d0a 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -2356,7 +2356,9 @@

void startProcessTextIntent(Intent intent) {

// on Android M, WebView is not able to replace the text with the processed text.

// So set the readonly flag for M.

- if (Build.VERSION.SDK_INT == Build.VERSION_CODES.M) {

+ // TODO(hush): remove the part about VERSION.CODENAME equality with N, after N release.

+ // crbug.com/543272

+ if (Build.VERSION.SDK_INT == Build.VERSION_CODES.M && !Build.VERSION.CODENAME.equals("N")) {

intent.putExtra(Intent.EXTRA_PROCESS_TEXT_READONLY, true);

}