Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 2745593002: Remove categories notified as invalid (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove categories notified as invalid Remove from the UI the categories marked as invalid by the backend content suggestion service. BUG=699124 Review-Url: https://codereview.chromium.org/2745593002 Cr-Commit-Position: refs/heads/master@{#456668} Committed: https://chromium.googlesource.com/chromium/src/+/b229390f77b9f716a57e17f9c5b9d93874917f88

Patch Set 1 #

Patch Set 2 : Add comment #

Messages

Total messages: 9 (4 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-09 15:31:35 UTC) #2
stkhapugin
lgtm but this needs to be tested.
3 years, 9 months ago (2017-03-10 13:28:57 UTC) #3
gambard
I will add EG tests once the UI is more stable
3 years, 9 months ago (2017-03-14 10:12:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745593002/20001
3 years, 9 months ago (2017-03-14 10:12:53 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 10:42:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b229390f77b9f716a57e17f9c5b9...

Powered by Google App Engine
This is Rietveld 408576698